Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather OpenStack resources data #188

Merged

Conversation

MaysaMacedo
Copy link
Contributor

This commit ensures all the OpenStack resources data handled
in Kuryr is gathered.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 12, 2020
@MaysaMacedo
Copy link
Contributor Author

/assign @dulek

@MaysaMacedo MaysaMacedo force-pushed the gather-openstack-data branch 2 times, most recently from 76ca1b6 to 32aa6ae Compare March 13, 2020 08:42
@MaysaMacedo
Copy link
Contributor Author

/test verify

1 similar comment
@MaysaMacedo
Copy link
Contributor Author

/test verify

@MaysaMacedo MaysaMacedo force-pushed the gather-openstack-data branch 2 times, most recently from b74628e to 2116200 Compare March 13, 2020 10:33
Copy link
Contributor

@dulek dulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'd love to see one small change here and I think this is okay.

kuryr_kubernetes/cmd/gather_openstack_data.py Outdated Show resolved Hide resolved
This commit ensures all the OpenStack resources data handled
in Kuryr is gathered.
@MaysaMacedo
Copy link
Contributor Author

/test images

2 similar comments
@MaysaMacedo
Copy link
Contributor Author

/test images

@MaysaMacedo
Copy link
Contributor Author

/test images

@MaysaMacedo
Copy link
Contributor Author

/retest

3 similar comments
@MaysaMacedo
Copy link
Contributor Author

/retest

@MaysaMacedo
Copy link
Contributor Author

/retest

@MaysaMacedo
Copy link
Contributor Author

/retest

@dulek
Copy link
Contributor

dulek commented Mar 16, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit db7622b into openshift:master Mar 16, 2020
@MaysaMacedo MaysaMacedo deleted the gather-openstack-data branch March 16, 2020 10:08
MaysaMacedo pushed a commit to MaysaMacedo/kuryr-kubernetes-1 that referenced this pull request Jul 1, 2021
Revert "Merge pull request openshift#183 from wking/revert-OVS-shutdown-change"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants