Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1943804: increases the maximum time for migration for the encryption tests on AWS #1076

Conversation

p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented May 13, 2021

In particular this PR:

  • properly detects if the tests are running in CI so that we get output with timeouts. Previously the output didn't have timestamps which made troubleshooting harder.

  • adds timestamps to logs to ease troubleshooting

  • increases the timeout for migration to 79 minutes:

-  rolling out a single instance on AWS: 3m 30s (max delay aws) + 60s (in-flight req) + 3m 10s (starting new instance - observation) = 7m 40s

-  rolling out all instances: 7m 40s * 3 = 23m

-  a happy path scenario needs to roll out 3 revisions each taking 23m

-  plus 10 additional minutes for actual migration

xref: openshift/cluster-kube-apiserver-operator#1079

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

@p0lyn0mial: This pull request references Bugzilla bug 1943804, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 1943804: fixes the encryption performance tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 13, 2021
@p0lyn0mial
Copy link
Contributor Author

/assign @sttts

@p0lyn0mial
Copy link
Contributor Author

/test unit

@p0lyn0mial p0lyn0mial force-pushed the encryption-test-wait-for-stable-revision branch 3 times, most recently from 896737b to 52d5ce5 Compare May 14, 2021 20:53
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

@p0lyn0mial: This pull request references Bugzilla bug 1943804, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 1943804: fixes the encryption performance tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

@p0lyn0mial: This pull request references Bugzilla bug 1943804, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 1943804: fixes the encryption performance tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ecryption to complete

observations:
 rolling out a single instance on AWS takes 3m 30s (max delay aws) + 60s (in-flight req) + 3m 10s (starting new instance - observation) = 7m 40s
 rolling out all instances on AWS 7m 40s * 3 = 23m
 a happy path scenario needs to roll out 3 revisions each taking 23m
@p0lyn0mial p0lyn0mial force-pushed the encryption-test-wait-for-stable-revision branch from 68c3da1 to 25baf46 Compare May 17, 2021 07:29
@p0lyn0mial p0lyn0mial changed the title Bug 1943804: fixes the encryption performance tests Bug 1943804: increases the maximum time for migration for the encryption tests on AWS May 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2021

@p0lyn0mial: This pull request references Bugzilla bug 1943804, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 1943804: increases the maximum time for migration for the encryption tests on AWS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2021

@p0lyn0mial: This pull request references Bugzilla bug 1943804, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 1943804: increases the maximum time for migration for the encryption tests on AWS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented May 17, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4f4c86d into openshift:master May 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2021

@p0lyn0mial: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1943804 has not been moved to the MODIFIED state.

In response to this:

Bug 1943804: increases the maximum time for migration for the encryption tests on AWS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants