Bug 1963730: moves the cert directory under the target directory #1098
Conversation
|
/assign @sttts |
The target directory holds all files for the current static pod manifest. As of today, kube-apiserver-certs is accessed by at least two processes, namely the installer pod and the cert-syncer. Up until now, there was no coordination between these processes that might have lead to many unexpected errors, like https://bugzilla.redhat.com/show_bug.cgi?id=1963730 Moving the cert directory to the target directory (revisioned) ensures that these processes won't step each other's toes. After this PR /etc/kubernetes/static-pod-resources/kube-apiserver-pod-REVISION/kube-apiserver-certs Previously it was /etc/kubernetes/static-pod-resources/kube-apiserver-certs
p0lyn0mial
force-pushed
the
with-revisioned-apiserver-certs-path
branch
from
ed13947
to
3b048eb
Compare
…econfig to cover multiple paths openshift/library-go#1098 moved the cert directory under a new path hence we need to cover both the old and the new paths
p0lyn0mial
changed the title
|
@p0lyn0mial: This pull request references Bugzilla bug 1963730, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-low
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@p0lyn0mial: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1963730 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…econfig to cover multiple paths openshift/library-go#1098 moved the cert directory under a new path hence we need to cover both the old and the new paths
…h-revisioned-apiserver-certs-path"" This reverts commit 71baae1.
…rver-certs-path Bug 1963730: revert #1098
The target directory holds all files for the current static pod manifest.
As of today, kube-apiserver-certs is accessed by at least two processes, namely the installer pod and the cert-syncer.
Up until now, there was no coordination between these processes that might have lead to many unexpected errors, like https://bugzilla.redhat.com/show_bug.cgi?id=1963730
Moving the cert directory to the target directory (revisioned) ensures that these processes won't step each other's toes.
After this PR /etc/kubernetes/static-pod-resources/kube-apiserver-pod-REVISION/kube-apiserver-certs
Previously it was /etc/kubernetes/static-pod-resources/kube-apiserver-certs