start informers after the listers have been requested #430
Conversation
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
size/S
|
/cherrypick release-4.1 |
|
@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm Tested in CI via openshift/cluster-kube-apiserver-operator#490 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@deads2k: new pull request created: #435 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| go controller.Run(1, stopCh) | ||
| go observer.Run(stopCh) | ||
| go kubeInformers.Start(stopCh) |
There was a problem hiding this comment.
nit: I think you don't have to start Kube informers in a separate "thread" because all informers will be run in a dedicated goroutine, see
maybe we could change the name of the method to StartAsync :)
start informers after the listers have been requested
also wait for the caches to fill
/assign @sanchezl
/hold
@sanchezl please make a fake bump