Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1779263: encryption: cope with missing revisions on upgrade #624

Merged
merged 1 commit into from Dec 3, 2019
Merged

Bug 1779263: encryption: cope with missing revisions on upgrade #624

merged 1 commit into from Dec 3, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Dec 3, 2019

On upgrade the openshift-apiserver pods have no revision making the encryption controller fall over.

@openshift-ci-robot
Copy link

@sttts: This pull request references Bugzilla bug 1779263, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1779263: encryption: cope with missing revisions on upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor Author

sttts commented Dec 3, 2019

/cherrypick release-4.3

@openshift-cherrypick-robot
Copy link

@sttts: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d07e245 into openshift:master Dec 3, 2019
@openshift-ci-robot
Copy link

@sttts: All pull requests linked via external trackers have merged. Bugzilla bug 1779263 has been moved to the MODIFIED state.

In response to this:

Bug 1779263: encryption: cope with missing revisions on upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 3, 2019
Merged
@openshift-cherrypick-robot
Copy link

@sttts: new pull request created: #625

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts sttts mentioned this pull request Dec 3, 2019
Merged
bertinatto pushed a commit to bertinatto/library-go that referenced this pull request Jul 2, 2020
@openshift-merge-robot
Merge pull request openshift#624 from sttts/sttts-encryption-no-revis…
445b745 
…ion-pods

Bug 1779263: encryption: cope with missing revisions on upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sttts @openshift-ci-robot @p0lyn0mial @openshift-cherrypick-robot @openshift-merge-robot