Bug 1887392: allow configuring authn/z caches TTLs #970
Conversation
openshift-ci-robot
added
do-not-merge/hold
|
@stlaz: This pull request references Bugzilla bug 1887392, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/retest |
|
@stlaz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
pkg/config/serving/server.go
Outdated
| @@ -58,6 +59,7 @@ func ToServerConfig(ctx context.Context, servingInfo configv1.HTTPServingInfo, a | |||
| if !authorizationConfig.Disabled { | |||
| authorizationOptions := genericapiserveroptions.NewDelegatingAuthorizationOptions() | |||
| authorizationOptions.RemoteKubeConfigFile = kubeConfigFile | |||
| authorizationOptions.AllowCacheTTL = authorizationConfig.AllowCacheTTL.Duration | |||
There was a problem hiding this comment.
it's 10s as set by the NewDelegatingAuthenticationOptions/NewDelegatingAuthorizationOptions functions
openshift-ci-robot
added
the
needs-rebase
|
depends on openshift/api#832 |
openshift-ci-robot
removed
the
needs-rebase
Most, if not all core components on the platform are using 30s as a timer for the /metrics endpoint. This increases authn/z cache TTL from the kube-original 10s to 35s to avoid delegating approx. every other metrics request to the API server.
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stlaz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
@stlaz: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1887392 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This should contribute to reducing traffic inside a cluster since not every metrics request to our operators (once every 30s per operator) will need to pass an authn/z check (tokenreview/SAR).
/assign @sttts
/hold
contains fake bump