Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades

[sanchezl]

No description provided.

[danwinship]

Suggested change

	// upgrade is in progress if there is no history, or the latest history entry matches the desired version and is completed
	if len(history) == 0 || !(history[0].Version == desired && history[0].State == configv1.CompletedUpdate) {
	// upgrade is in progress if there is no history, or the latest history entry matches the desired version and is not completed
	if len(history) == 0 || !(history[0].Version == desired && history[0].State == configv1.CompletedUpdate) {

?

[sanchezl]

Updated

[deads2k]

Are you sure this logic is correct? I expected (and have easier time reading)

if len(history) == 0{
  klog.V(1).Infof("ConnectivityCheckController is waiting for transition to first desired version (%s) to be completed.", desired)
  return nil
}
if history[0].Version != desired{
  klog.V(1).Infof("ConnectivityCheckController is waiting for transition to desired version (%s) to be started.", desired)
  return nil
}

// this one looks different from what you wrote above....
if history[0].State != configv1.CompletedUpdate{
  klog.V(1).Infof("ConnectivityCheckController is waiting for transition to desired version (%s) to be completed.", desired)
  return nil
}

[sanchezl]

Yes, I had a == that should of been a != there. I'll split it out as per your suggestion.

[sanchezl]

Updated.

[deads2k]

/lgtm

release the hold when you're confident your proof works.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sanchezl: This pull request references Bugzilla bug 1912820, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sanchezl]

/hold cancel

[openshift-ci-robot]

@sanchezl: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/cluster-kube-apiserver-operator#1036 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1912820 has not been moved to the MODIFIED state.

In response to this:

Bug 1912820: competing connectivitycheckcontrollers cause pod restarts during upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.