Bug 2010174: Fix duplicate PVs for disk by-names

[gnufied]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2010174

[openshift-ci]

@gnufied: This pull request references Bugzilla bug 2010174, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2010174: Fix duplicate PVs for disk by-names

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gnufied]

/bugzilla refresh

[openshift-ci]

@gnufied: This pull request references Bugzilla bug 2010174, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

Minor nit: you could use for _, pv := range pvs like you did on line 276 and avoid the extra pv := pvs[i] line. Purely optional.

[gnufied]

I was doing that on purpose to avoid globbering of loop variables by goroutines. I know that is not the case here, but I am trying to adopt this pattern as matter of style rather than only when needed.

[dobsonj]

Ok that's fine, just caught my eye.

[dobsonj]

When we're populating the cache here, is it possible to get a competing addOrUpdatePV call via CreateFunc?

local-storage-operator/diskmaker/controllers/lv/reconcile.go

Lines 678 to 683 in 3defd5e

	CreateFunc: func(e event.CreateEvent, q workqueue.RateLimitingInterface) {
	pv, ok := e.Object.(*corev1.PersistentVolume)
	if ok {
	handlePVChange(runtimeConfig, pv, q, false)
	}
	},

If so, what would happen in that case? Could we end up with the same PV added twice?

[gnufied]

The PVs in cache are keyed by volume names, which is supposed to be a unique string cluster-wide and hence last update will win I think. For our purpose here, it won't matter I think.

[dobsonj]

/lgtm

[openshift-ci]

@gnufied: All pull requests linked via external trackers have merged:

• openshift/local-storage-operator#292

Bugzilla bug 2010174 has been moved to the MODIFIED state.

In response to this:

Bug 2010174: Fix duplicate PVs for disk by-names

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.