Bug 2109258: add more support for old delete annotation

[elmiko]

this change adds detection to the newest and random delete priority
functions to ensure that we have coverage for the older annotation until
it is removed. also updates the tests to cover a situation where the old
annotation was not detected properly and adds more tests for the new
interactions.

[openshift-ci]

@elmiko: This pull request references Bugzilla bug 2109258, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 2109258: add more support for old delete annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@elmiko: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack	4db76a6	link	false	/test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi	4db76a6	link	false	/test e2e-metal-ipi
ci/prow/e2e-libvirt	4db76a6	link	false	/test e2e-libvirt
ci/prow/e2e-azure-operator	4db76a6	link	false	/test e2e-azure-operator
ci/prow/e2e-aws-disruptive	4db76a6	link	false	/test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-upgrade	4db76a6	link	false	/test e2e-metal-ipi-upgrade
ci/prow/e2e-metal-ipi-virtualmedia	4db76a6	link	false	/test e2e-metal-ipi-virtualmedia

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@elmiko: All pull requests linked via external trackers have merged:

• openshift/machine-api-operator#1042

Bugzilla bug 2109258 has been moved to the MODIFIED state.

In response to this:

Bug 2109258: add more support for old delete annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

Grepping around to confirm that this doesn't need a backport, the pivot away from the old annotation began in 10a5e77 (#1024), and that merged after 4.11 forked off, so we don't need a 4.11 backport here.