New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kubevirt provider #716
Add Kubevirt provider #716
Conversation
@nirarg: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
CI images creation depends on openshift/release#12318 (hopefully merged soon) |
7672ef2
to
8cf2f1a
Compare
spec: | ||
secretRef: | ||
namespace: openshift-machine-api | ||
# This is the of the new secret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "This is the name of the new secret"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the comment
8cf2f1a
to
cb0d32e
Compare
/retest |
Changes here look fine, please add a description to the PR before we merge We have a script that pushes updates to MAO out to repositories that depend on this repo, you may want to add kubevirt to this list machine-api-operator/hack/push-updates.sh Lines 45 to 51 in 1842a55
|
cb0d32e
to
82d5cb1
Compare
Hi @JoelSpeed, thank you for the review |
@nirarg Great, please ping me once that's done and you're ready to look at getting this merged, I don't think I have any further feedback at this time |
82d5cb1
to
5f2c63c
Compare
/retest |
1 similar comment
/retest |
Hi @JoelSpeed , I removed the |
/approve One question I do have though, seems we are using |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @JoelSpeed |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@nirarg: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR is part of task done to add KubeVirt platform as infra provider for Openshift.
The change introduced in this PR purpose is to provide a way to install Openshift on KubeVirt infrastructure
For more information, please find the enhancement PR:
openshift/enhancements#417
Related PRs/changes done as part of this task:
Also adding this project's image to openshift is in progress
Additional job is done to have tests and CI coverage (work in progress in github.com/openshift/release repository)