Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2002262: Fix user-agent in vCenter sessions list #912

Merged
merged 1 commit into from Sep 8, 2021

Conversation

lobziik
Copy link
Contributor

@lobziik lobziik commented Sep 7, 2021

For some reason vCenter using user-agent from first
login request and does not respect it's change after.
Moved login step into our code with setting user-agent
for soap client beforehand.
Info log message for new vCenter session creation added
by the way.

tested on vCenter 7.0.1.00200

pkg/controller/vsphere/session/session.go Outdated Show resolved Hide resolved
@@ -67,6 +67,7 @@ func GetOrCreate(
return &session, nil
}
}
klog.Infof("Create new vcenter session")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this definitely something we want? If so, I'd suggest

Suggested change
klog.Infof("Create new vcenter session")
klog.Infof("No existing vCenter session found, creating new session")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should appear just once during controller startup. IMHO would be nice to have such message.

Updated message

For some reason vCenter using user-agent from first
login request and does not respect it's change after.
Moved login step into our code with setting user-agent
for soap client beforehand.
Info log message for new vCenter session creation added
by the way.
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this generally makes sense to me
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@lobziik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive 4601d06 link /test e2e-aws-disruptive
ci/prow/e2e-libvirt 4601d06 link /test e2e-libvirt
ci/prow/e2e-azure 4601d06 link /test e2e-azure
ci/prow/e2e-openstack 4601d06 link /test e2e-openstack
ci/prow/e2e-gcp-operator 4601d06 link /test e2e-gcp-operator
ci/prow/e2e-azure-operator 4601d06 link /test e2e-azure-operator
ci/prow/e2e-vsphere 4601d06 link /test e2e-vsphere
ci/prow/e2e-vsphere-operator 4601d06 link /test e2e-vsphere-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thanks

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@JoelSpeed
Copy link
Contributor

Is it worth creating a BZ for this and backporting it to 4.9/4.8?

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4ef7cc4 into openshift:master Sep 8, 2021
@lobziik
Copy link
Contributor Author

lobziik commented Sep 8, 2021

Is it worth creating a BZ for this and backporting it to 4.9/4.8?

Yeah, worth to backport. Will do.

@lobziik lobziik changed the title Fix user-agent in vCenter sessions list Bug 2002262: Fix user-agent in vCenter sessions list Sep 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

@lobziik: All pull requests linked via external trackers have merged:

Bugzilla bug 2002262 has been moved to the MODIFIED state.

In response to this:

Bug 2002262: Fix user-agent in vCenter sessions list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lobziik
Copy link
Contributor Author

lobziik commented Sep 8, 2021

/bugzilla-refresh

@JoelSpeed
Copy link
Contributor

/cherry-pick release-4.9

@openshift-cherrypick-robot

@JoelSpeed: new pull request created: #918

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants