Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2040504: Ensure IOPS setting is honoured on all supported block device types #18

Merged
merged 1 commit into from Jan 15, 2022
Merged

Bug 2040504: Ensure IOPS setting is honoured on all supported block device types #18

merged 1 commit into from Jan 15, 2022

Conversation

JoelSpeed
Copy link
Contributor

AWS documentation suggests that IO1, IO2 and GP3 block devices all support a configurable IOPS setting. We are only allowing this for IO1 right now, so we should make sure that we set the IOPS on other supported types as well.

The following are the supported values for each volume type:

  • gp3 : 3,000-16,000 IOPS
  • io1 : 100-64,000 IOPS
  • io2 : 100-64,000 IOPS

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

@JoelSpeed: This pull request references Bugzilla bug 2040504, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 2040504: Ensure IOPS setting is honoured on all supported block device types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member

damdo commented Jan 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
alexander-demicev
alexander-demicev approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@lobziik
Copy link
Contributor

lobziik commented Jan 14, 2022

/lgtm

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@JoelSpeed
Copy link
Contributor Author

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
Fedosin
Fedosin approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 36de10b into openshift:main Jan 15, 2022
10 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2022

@JoelSpeed: All pull requests linked via external trackers have merged:

Bugzilla bug 2040504 has been moved to the MODIFIED state.

In response to this:

Bug 2040504: Ensure IOPS setting is honoured on all supported block device types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member

damdo commented Mar 18, 2022

/cherry-pick release-4.9

@openshift-cherrypick-robot
Copy link

@damdo: cannot checkout release-4.9: error checking out release-4.9: exit status 1. output: error: pathspec 'release-4.9' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo damdo mentioned this pull request Mar 18, 2022
Merged
@damdo
Copy link
Member

damdo commented Mar 18, 2022

That's because 4.9 is on a different repo. I did a manual cherry pick to that here: openshift/cluster-api-provider-aws#436

@JoelSpeed JoelSpeed deleted the iops-gp3 branch March 18, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedosin Fedosin Fedosin approved these changes

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@lobziik lobziik Awaiting requested review from lobziik

Assignees

@lobziik lobziik

@damdo damdo

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@JoelSpeed @damdo @openshift-bot @lobziik @openshift-cherrypick-robot @Fedosin @alexander-demicev @openshift-merge-robot