From b177e329000428336a81fc5f34bc6ecbb3d6149a Mon Sep 17 00:00:00 2001 From: Damiano Donati Date: Wed, 30 Aug 2023 16:37:04 +0200 Subject: [PATCH] fix: run tests natively by default Tests like lint and vet used to be ran within a container engine by default if an engine was detected, both locally and in CI. Up until now no container engine was detected in CI, so tests would run natively there. Now that the base image we use in CI has now started shipping `podman`, a container engine is detected by default and tests are run within podman by default. But creating nested containers doesn't work in CI at the moment and thus results in a test failure. As such we are switching the default behaviour for tests (both locally and in CI), where now by default no container engine is used to run tests, even if one is detected, but instead tests are run natively unless otherwise specified. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 62c7ab548..5bd438662 100644 --- a/Makefile +++ b/Makefile @@ -45,7 +45,7 @@ export GOPROXY GOARCH ?= $(shell go env GOARCH) GOOS ?= $(shell go env GOOS) -NO_DOCKER ?= 0 +NO_DOCKER ?= 1 ifeq ($(shell command -v podman > /dev/null 2>&1 ; echo $$? ), 0) ENGINE=podman