Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCPBUGS-380] Update Machine API Operator dependency to fix phase transition metric #33

Merged

Conversation

JoelSpeed
Copy link
Contributor

This PR updates MAO to include the fix for the phase transition metric.

/hold until it's merged and I fixup the replace

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 31, 2022
@openshift-ci openshift-ci bot requested review from enxebre and lobziik August 31, 2022 14:30
@JoelSpeed JoelSpeed changed the title [WIP][OCPBUGS-380] Update Machine API Operator dependency to fix phase transition metric [OCPBUGS-380] Update Machine API Operator dependency to fix phase transition metric Sep 5, 2022
@JoelSpeed
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 5, 2022
@lobziik
Copy link
Contributor

lobziik commented Sep 5, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2022
@JoelSpeed
Copy link
Contributor Author

/retest-required

4 similar comments
@JoelSpeed
Copy link
Contributor Author

/retest-required

@JoelSpeed
Copy link
Contributor Author

/retest-required

@JoelSpeed
Copy link
Contributor Author

/retest-required

@JoelSpeed
Copy link
Contributor Author

/retest-required

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@JoelSpeed
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3165adc and 2 for PR HEAD 68d198d in total

@damdo
Copy link
Member

damdo commented Sep 13, 2022

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@JoelSpeed
Copy link
Contributor Author

Had to rebase to resolve a conflict in the go.mod

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7ff507e and 2 for PR HEAD eb5ca69 in total

@JoelSpeed
Copy link
Contributor Author

/retest-required

1 similar comment
@JoelSpeed
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure eb5ca69 link false /test e2e-azure
ci/prow/e2e-upgrade eb5ca69 link false /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor Author

/override ci/prow/e2e-azure-operator

The autoscaler tests are known to be flaky right now

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2022

@JoelSpeed: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ``

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-azure
  • ci/prow/e2e-azure-operator
  • ci/prow/e2e-upgrade
  • ci/prow/goimports
  • ci/prow/govet
  • ci/prow/images
  • ci/prow/unit
  • pull-ci-openshift-machine-api-provider-azure-main-e2e-azure
  • pull-ci-openshift-machine-api-provider-azure-main-e2e-azure-operator
  • pull-ci-openshift-machine-api-provider-azure-main-e2e-upgrade
  • pull-ci-openshift-machine-api-provider-azure-main-goimports
  • pull-ci-openshift-machine-api-provider-azure-main-govet
  • pull-ci-openshift-machine-api-provider-azure-main-images
  • pull-ci-openshift-machine-api-provider-azure-main-unit
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/e2e-azure-operator

The autoscaler tests are known to be flaky right now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor Author

/override ci/prow/e2e-azure-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-azure-operator

In response to this:

/override ci/prow/e2e-azure-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e62926d into openshift:main Sep 15, 2022
@JoelSpeed JoelSpeed deleted the fix-phase-transition branch September 15, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants