New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.12] OCPBUGS-10603: machineset_controller: Stop caching clouds credentials #65
[release-4.12] OCPBUGS-10603: machineset_controller: Stop caching clouds credentials #65
Conversation
Before this change, a failure in retrieving flavor information from OpenStack would trigger a generic event. With this patch, the warning event signaling failure to retrieve flavor information contains the original error coming from the OpenStack API.
Caching causes at least two problems: * the secret where to look for clouds.yaml is a property of each MachineSet (`cloudsSecret` in the Machine template). However, we were caching clouds.yaml from the first MachineSet we encountered, and using the same for all MachineSets from that point on. * by caching (and never invalidating) the OpenStack service client, we were not picking up any change to the clouds.yaml itself: for example, if the user rotated the cluster's OpenStack credentials.
@pierreprinetti: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
/jira cherrypick OCPBUGS-10558 |
@pierreprinetti: Jira Issue OCPBUGS-10558 has been cloned as Jira Issue OCPBUGS-10603. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierreprinetti: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierreprinetti: This pull request references Jira Issue OCPBUGS-10603, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierreprinetti: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierreprinetti: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc mandre |
/cherrypick release-4.11 |
@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierreprinetti: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/label backport-risk-assessed
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@pierreprinetti: This pull request references Jira Issue OCPBUGS-10603, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @eurijon |
/label cherry-pick-approved |
c6d1737
into
openshift:release-4.12
@pierreprinetti: Jira Issue OCPBUGS-10603: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-10603 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierreprinetti: new pull request created: #67 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierreprinetti: new pull request could not be created: failed to create pull request against openshift/machine-api-provider-openstack#release-4.11 from head openshift-cherrypick-robot:cherry-pick-65-to-release-4.11: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-65-to-release-4.11."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-api-provider-openstack-container-v4.12.0-202305022015.p0.gc6d1737.assembly.stream for distgit ose-machine-api-provider-openstack. |
This is a manual cherry-pick of #64