Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Substitute pkg/ with internal/ #398
Code within pkg/ here is by no mean intended to be used outside of this project. Since Go 1.4 we can move everything under pkg/ to internal/ so we can only use our stuff and nobody else could vendor and use it (that's our code and not intended to be imported anyway). Go enforces it of course https://golang.org/doc/go1.4#internalpackages
I'm also trying to understand if code under lib/ is just a fork, or it's properly vendored with dep or whatever. In case it's not, we need to work that out to make into vendor as well if it's reusable code. Of course, lib/ is also meant to be used by just ourselves so move it under internal/ as well
The following packages are most definitely supposed to be used outside this project.
while these can be used outside: