docs: update SSH docs to add keys #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/M
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
runcom
changed the title
added the 4.3 brackets in the title if that was what the hold was for :) |
Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
update-ssh-docs
branch
from
2e55118
to
f4ff500
Compare
kikisdeliveryservice
approved these changes
Aug 23, 2019
runcom
removed
the
do-not-merge/hold
kikisdeliveryservice
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://bugzilla.redhat.com/show_bug.cgi?id=1744940 it's clear that we're missing on documentation about how to add ssh keys. Fix that.