Bug 1757836: pkg/daemon: add check for logger in CentOS #1111
Conversation
openshift-ci-robot
added
the
size/XS
runcom
added
the
do-not-merge/hold
|
cc @mrguitar for awareness |
|
In the commit I see: Can you fix this to be the committer? Not sure what this is... |
I just pushed with root user by error, that's the reason of it. I amended. |
kikisdeliveryservice
changed the title
runcom
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom, yrobla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
runcom
changed the title
|
@yrobla: All pull requests linked via external trackers have merged. Bugzilla bug 1757836 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently this check for journal is just executed in the case of RHEL (for 7.6) . But with CentOS we are in the same situation.
So the fix is as simple as to add the CentOS check to the conditional.
In order to verify it, i just added a CentOS worker. Before that, it was failing in MCP with that logger failure. With the patch, node reports fine.
- Description for the changelog
Add check for logger in CentOS