New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon/update_test.go: Add TestReconcilable #117

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ashcrow
Member

ashcrow commented Oct 9, 2018

Running tool: /usr/bin/go test -timeout 30s -run ^TestReconcilable$

PASS
ok  	github.com/openshift/machine-config-operator/pkg/daemon	0.008s
Success: Tests passed.

Kind of part of #101

/cc @sdemos @kikisdeliveryservice @jlebon

daemon/update_test.go: Add TestReconcilable
Signed-off-by: Steve Milner <smilner@redhat.com>
@openshift-ci-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-ci-robot

openshift-ci-robot Oct 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot commented Oct 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon

Seems sane, just a couple of typos! Hmm, wonder if there's a way to make it less verbose though. In Python, we could probably leverage getattr or something.

t.Errorf("Expected no error. Got %s.", err)
}
if isReconcilable != false {
t.Errorf("Expected different ignition versions would cause irreconcilable. Recieved reconcilable.")

This comment has been minimized.

@jlebon

jlebon Oct 10, 2018

Member

Minor: s/Recieved/Received/ (and below)

@jlebon

jlebon Oct 10, 2018

Member

Minor: s/Recieved/Received/ (and below)

t.Errorf("Expected no error. Got %s.", err)
}
if isReconcilable != true {
t.Errorf("Expected the same ignition version would cause reconsilable. Recieved irreconcilable.")

This comment has been minimized.

@jlebon

jlebon Oct 10, 2018

Member

Minor: s/reconsilable/reconcilable/

@jlebon

jlebon Oct 10, 2018

Member

Minor: s/reconsilable/reconcilable/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment