Skip to content

Bug 1772900: bump mco deps for TLSSecurityProfile and ExperimentalCriticalPodAnnotation featuregate removal #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2019
Merged

Bug 1772900: bump mco deps for TLSSecurityProfile and ExperimentalCriticalPodAnnotation featuregate removal #1257

merged 2 commits into from
Nov 20, 2019

Conversation

@rphillips
Copy link
Contributor

@rphillips rphillips commented Nov 11, 2019 •
edited
Loading

- What I did
Bumps deps to get the new openshift/api featuregate changes (remove TLSSecurityProfile and ExperimentalCriticalPodAnnotation).

- How to verify it
Unit tests

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 11, 2019
@rphillips rphillips changed the title Fixes/bump mco deps bump mco deps for TLSSecurityProfile and ExperimentalCriticalPodAnnotation featuregate removal Nov 11, 2019
@rphillips
Copy link
Contributor Author

rphillips commented Nov 11, 2019

/retest

2 similar comments
@rphillips
Copy link
Contributor Author

rphillips commented Nov 12, 2019

/retest

@rphillips
Copy link
Contributor Author

rphillips commented Nov 12, 2019

/retest

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Nov 12, 2019

Do we need a BZ to merge this?

@kikisdeliveryservice kikisdeliveryservice requested review from kikisdeliveryservice and removed request for LorbusChris November 12, 2019 15:22
@rphillips
Copy link
Contributor Author

rphillips commented Nov 12, 2019

/retest

1 similar comment
@ravisantoshgudimetla
Copy link
Contributor

ravisantoshgudimetla commented Nov 15, 2019

/retest

@sdodson
Copy link
Member

sdodson commented Nov 15, 2019

/retitle Bug 1772900: bump mco deps for TLSSecurityProfile and ExperimentalCriticalPodAnnotation featuregate removal

@openshift-ci-robot openshift-ci-robot changed the title bump mco deps for TLSSecurityProfile and ExperimentalCriticalPodAnnotation featuregate removal Bug 1772900: bump mco deps for TLSSecurityProfile and ExperimentalCriticalPodAnnotation featuregate removal Nov 15, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 15, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 15, 2019

@rphillips: This pull request references Bugzilla bug 1772900, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1772900: bump mco deps for TLSSecurityProfile and ExperimentalCriticalPodAnnotation featuregate removal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Nov 15, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 15, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 15, 2019

@sdodson: This pull request references Bugzilla bug 1772900, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 15, 2019
@sinnykumari
Copy link
Contributor

sinnykumari commented Nov 15, 2019

/retest

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Nov 15, 2019

this is consistently failing: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/1257/pull-ci-openshift-machine-config-operator-master-e2e-aws/5712

Would rec debugging kubelet logs & master journals to see where these changes are breaking

@sdodson
Copy link
Member

sdodson commented Nov 19, 2019

@rphillips any idea regarding the persistent failure?
/test e2e-aws

@cgwalters
Copy link
Member

cgwalters commented Nov 19, 2019

This error occurs when the bootstrap and controller generated configs differ.

One offhand guess I have is that the kubelet config controller's createNewDefaultFeatureGate() needs to be bumped too?

@rphillips
Copy link
Contributor Author

rphillips commented Nov 19, 2019 •
edited
Loading

@cgwalters The dependency within createNewDefaultFeatureGate() was bumped within this patch...

@rphillips
Copy link
Contributor Author

rphillips commented Nov 19, 2019

I found an issue with the dependency bump... going to retry the build

@rphillips
Copy link
Contributor Author

rphillips commented Nov 19, 2019

/test e2e-gcp-upgrade

@rphillips
Copy link
Contributor Author

rphillips commented Nov 19, 2019

@cgwalters this is ready for a review

@sinnykumari
Copy link
Contributor

sinnykumari commented Nov 20, 2019

LGTM

/approve

@cgwalters
Copy link
Member

cgwalters commented Nov 20, 2019

Ah yep, it was the openshift/api still including a feature.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, rphillips, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2019
@openshift-merge-robot openshift-merge-robot merged commit e903354 into openshift:master Nov 20, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2019

@rphillips: All pull requests linked via external trackers have merged. Bugzilla bug 1772900 has been moved to the MODIFIED state.

In response to this:

Bug 1772900: bump mco deps for TLSSecurityProfile and ExperimentalCriticalPodAnnotation featuregate removal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

deads2k added a commit to deads2k/machine-config-operator that referenced this pull request Dec 13, 2019
@deads2k
Revert "Merge pull request openshift#1257 from rphillips/fixes/bump_m…
13a803d 
…co_deps"

This reverts commit e903354, reversing
changes made to 2e560b2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericavonb ericavonb Awaiting requested review from ericavonb

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@cgwalters cgwalters

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@rphillips @kikisdeliveryservice @ravisantoshgudimetla @sdodson @openshift-ci-robot @sinnykumari @cgwalters @openshift-merge-robot