New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/daemon: gofmt changes #149

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@sdemos
Contributor

sdemos commented Oct 30, 2018

my editor runs gofmt on write and I ran into these because of that.

I wonder if we can hook gofmt into the merge bot somehow?

/cc @ashcrow

@openshift-ci-robot

This comment has been minimized.

openshift-ci-robot commented Oct 30, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdemos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashcrow

This comment has been minimized.

Member

ashcrow commented Oct 30, 2018

Thanks for this @sdemos. If possible, do you mind looking at #126? If that's close I can pull this in after that merges (or part of it). I'm trying not to rebase for a 4th time 😆.

@ashcrow

This comment has been minimized.

Member

ashcrow commented Nov 6, 2018

/hold

@ashcrow

This comment has been minimized.

Member

ashcrow commented Nov 8, 2018

/close

We'll take care of this in a clean up PR.

@openshift-ci-robot

This comment has been minimized.

openshift-ci-robot commented Nov 8, 2018

@ashcrow: Closing this PR.

In response to this:

/close

We'll take care of this in a clean up PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow ashcrow referenced this pull request Nov 9, 2018

Merged

Misc clean up #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment