Bug 1826021: Fix a problem with a greedy regular expression matching more than needed

[retroflexer]

Closes: 1826021
- What I did
Fixed a problem with a greedy regular expression.
- How to verify it
Run restore on a master which is not the first one in the ETCD_INITIAL_CLUSTER. It should finish successfully.

- Description for the changelog

Current restore shell script results in an error "Error: snapshot restore requires exactly one argument" if the attempted master in not the first member listed in the ETCD_INITIAL_CLUSTER. This is due to a bug in the regular expression.

[openshift-ci-robot]

@retroflexer: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix a problem with a greedy regular expression matching more than needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[retroflexer]

Compare the outputs from test 1, test 2 and test 3 patterns. The pattern used in this script is test 3. Originally the code had a pattern of test 1.

export ETCD_INITIAL_CLUSTER="etcd-0.example.com=https://etcd-0.example.com:2380,etcd-1.example.com=https://etcd-1.example.com:2380,etcd-2.example.com=https://etcd-2.example.com:2380"
  
  for ETCD_DNS_NAME in "etcd-0.example.com"  "etcd-1.example.com"  "etcd-2.example.com" 
  do
    echo "################## Trying with $ETCD_DNS_NAME"
    echo "test 1"
    echo ${ETCD_INITIAL_CLUSTER} | grep -oP "(?<=)[^,,\s]*(?==[^=]*${ETCD_DNS_NAME}\b)"
    echo "test 2"
    echo ${ETCD_INITIAL_CLUSTER} | grep -oP "(?<=,)${ETCD_DNS_NAME}(?==)"
    echo "test 3"
    echo ${ETCD_INITIAL_CLUSTER} | grep -oP "[^,\s]*(?==[^=,]*${ETCD_DNS_NAME}\b)"
  done

	
### Output
################## Trying with etcd-0.example.com
test 1
etcd-0.example.com
test 2
test 3
etcd-0.example.com
################## Trying with etcd-1.example.com
test 1
etcd-0.example.com
etcd-1.example.com
test 2
etcd-1.example.com
test 3
etcd-1.example.com
################## Trying with etcd-2.example.com
test 1
etcd-1.example.com
etcd-2.example.com
test 2
etcd-2.example.com
test 3
etcd-2.example.com

[openshift-ci-robot]

@retroflexer: This pull request references Bugzilla bug 1826021, which is invalid:

• expected the bug to target the "4.3.z" release, but it targets "4.6.0" instead
• expected Bugzilla bug 1826021 to depend on a bug targeting a release in 4.4.0, 4.4.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1826021: Fix a problem with a greedy regular expression matching more than needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hexfusion]

/lgtm

[retroflexer]

/bugzilla refresh

[openshift-ci-robot]

@retroflexer: This pull request references Bugzilla bug 1826021, which is invalid:

• expected Bugzilla bug 1826021 to depend on a bug targeting a release in 4.4.0, 4.4.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[retroflexer]

/test e2e-aws-scaleup-rhel7

[openshift-bot]

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

[openshift-ci-robot]

@openshift-bot: This pull request references Bugzilla bug 1826021, which is invalid:

• expected the bug to target the "4.3.z" release, but it targets "---" instead
• expected Bugzilla bug 1826021 to depend on a bug targeting a release in 4.4.0, 4.4.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[retroflexer]

/bugzilla refresh

[openshift-ci-robot]

@retroflexer: This pull request references Bugzilla bug 1826021, which is invalid:

• expected Bugzilla bug 1826021 to depend on a bug targeting a release in 4.4.0, 4.4.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[runcom]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ashcrow]

Adding valid-bug since the file is not present in 4.4+ so there is no backporting.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[retroflexer]

/retest

[openshift-ci-robot]

@retroflexer: All pull requests linked via external trackers have merged: . Bugzilla bug 1826021 has been moved to the MODIFIED state.

In response to this:

Bug 1826021: Fix a problem with a greedy regular expression matching more than needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.