Bug 1872632: allow overriding kubelet --node-ip in the _base templates

[danwinship]

This is not a complete fix for bug 1872632. However, regardless of the approach taken there, it seems like there needs to be some way for platform-none UPI users to override an incorrect guess by kubelet regarding the node IP. Currently we allowing overriding it (based on nodeip-configuration.service) in bare metal IPI, openstack, and vsphere, but not anywhere else.

This just patches the _base kubelet service files so that if KUBELET_NODE_IP has been set, somewhere, we pass it to kubelet. It does not actually provide any simple way to set it yet. (nodeip-configuration.service won't work on UPI because it requires there to be an apiserver VIP.)

The idea of making --node-ip configurable was somewhat rejected in #944 although in that case it was clear that the user only needed it to work around a bug somewhere else (which may or may not also be true for bz 1872632, but it's certainly the case that in some platform-none UPI installs, kubelet will not be able to correctly guess the node IP). But we could add {{ if eq .Infra.Status.PlatformStatus.Type "None" }} around the new code if we wanted to not allow overriding --node-ip on cloud platforms...

(I believe I'm correctly differentiating "bare metal platform" / "no platform" / IPI / UPI here but I may have gotten some of the details wrong)

cc @kikisdeliveryservice

[openshift-ci-robot]

@danwinship: This pull request references Bugzilla bug 1872632, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872632: allow overriding kubelet --node-ip in the _base templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dcbw]

ovn-step-registry seems to be the CI test pod not correctly starting, not even getting to the point of AWS setup
/retest

[dcbw]

/lgtm

[cgwalters]

This just patches the _base kubelet service files so that if KUBELET_NODE_IP has been set, somewhere, we pass it to kubelet. It does not actually provide any simple way to set it yet.

Presumably it'd work to write a systemd-drop in like /etc/systemd/system/kubelet.service.d/80-nodeip.conf

[Service]
Environment=KUBELET_NODE_IP=10.x.x.x

?

[cgwalters]

OK

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, danwinship, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• templates/master/01-master-kubelet/OWNERS [cgwalters]
• templates/worker/01-worker-kubelet/OWNERS [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@danwinship: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-workers-rhel7	0e9f7ab	link	/test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@danwinship: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#2088

Bugzilla bug 1872632 has been moved to the MODIFIED state.

In response to this:

Bug 1872632: allow overriding kubelet --node-ip in the _base templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danwinship]

Presumably it'd work to write a systemd-drop in like /etc/systemd/system/kubelet.service.d/80-nodeip.conf

I was thinking "edit /etc/kubernetes/kubelet-env" since the unit file sources that. But anyway, I just meant that this doesn't provide any way to automatically set the node IP. The user would still have to fiddle with machine configs or whatever to do that, at this point