New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HACKING.md: Tweak development instructions #217

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
6 participants
@cgwalters
Contributor

cgwalters commented Dec 6, 2018

  • The exact versions we tested with were quite old, no reason
    to have those now.
  • Use oc scale --replicas=0 for the CVO so it's easy to turn
    back on
  • Add note about oc project for shorthand
  • Use 1. to let the Markdown renderer take care of incrementing
    integers for us
@jlebon

This comment has been minimized.

Member

jlebon commented Dec 6, 2018

Use 1. to let the Markdown renderer take care of incrementing
integers for us

Oh neat, didn't realize it did that.

/lgtm

@ashcrow

This comment has been minimized.

Member

ashcrow commented Dec 6, 2018

/kind documentation

@kikisdeliveryservice

This comment has been minimized.

Member

kikisdeliveryservice commented Dec 6, 2018

@cgwalters how do we turn it back on? with oc scale? Could we maybe add that too?

@ashcrow

This comment has been minimized.

Member

ashcrow commented Dec 6, 2018

/test e2e-aws

HACKING.md: Tweak development instructions
 - The exact versions we tested with were quite old, no reason
   to have those now.
 - Use `oc scale --replicas=0` for the CVO so it's easy to turn
   back on
 - Add note about `oc project` for shorthand
 - Use `1.` to let the Markdown renderer take care of incrementing
   integers for us

@cgwalters cgwalters force-pushed the cgwalters:scale-cvo branch from 0e67ca1 to 6007309 Dec 6, 2018

@cgwalters

This comment has been minimized.

Contributor

cgwalters commented Dec 6, 2018

@cgwalters how do we turn it back on? with oc scale? Could we maybe add that too?

Yep, done.

@ashcrow

This comment has been minimized.

Member

ashcrow commented Dec 6, 2018

/test e2e-aws

@kikisdeliveryservice

This comment has been minimized.

Member

kikisdeliveryservice commented Dec 6, 2018

This is great @cgwalters !

@kikisdeliveryservice

This comment has been minimized.

Member

kikisdeliveryservice commented Dec 6, 2018

/lgtm

@openshift-ci-robot

This comment has been minimized.

openshift-ci-robot commented Dec 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters

This comment has been minimized.

Contributor

cgwalters commented Dec 7, 2018

/retest

@ashcrow

This comment has been minimized.

Member

ashcrow commented Dec 7, 2018

/test e2e-aws

Flake. I doubt this documentation affects HAProxy 😆

@jlebon

This comment has been minimized.

Member

jlebon commented Dec 7, 2018

/test e2e-aws

4 similar comments
@ashcrow

This comment has been minimized.

Member

ashcrow commented Dec 7, 2018

/test e2e-aws

@cgwalters

This comment has been minimized.

Contributor

cgwalters commented Dec 7, 2018

/test e2e-aws

@ashcrow

This comment has been minimized.

Member

ashcrow commented Dec 7, 2018

/test e2e-aws

@cgwalters

This comment has been minimized.

Contributor

cgwalters commented Dec 10, 2018

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit d991d61 into openshift:master Dec 11, 2018

5 checks passed

ci/prow/e2e-aws Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/rhel-images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment