Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.7] Bug 1956749: vsphere: platform none, vmxnet3v4 fix move to base #2564

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2559

/assign cuppett

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1952358 has been cloned as Bugzilla bug 1956749. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1956749: vsphere: platform none, vmxnet3v4 fix move to base

In response to this:

[release-4.7] Bug 1952358: vsphere: platform none, vmxnet3v4 fix move to base

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1952358: vsphere: platform none, vmxnet3v4 fix move to base [release-4.7] Bug 1956749: vsphere: platform none, vmxnet3v4 fix move to base May 4, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 4, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1956749, which is invalid:

  • expected dependent Bugzilla bug 1952358 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1956749: vsphere: platform none, vmxnet3v4 fix move to base

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The template is being moved from `templates/common/vsphere`
which is only applied when `platform: vsphere` is set.

There are customers running `platform: none` on vSphere or ESXi directly
that can be effected by the vmxnet3v4 issue.
@cuppett cuppett removed their assignment May 4, 2021
@jcpowermac
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: This pull request references Bugzilla bug 1956749, which is invalid:

  • expected dependent Bugzilla bug 1952358 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow ashcrow requested a review from yuqi-zhang May 4, 2021 12:48
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021
@ashcrow
Copy link
Member

ashcrow commented May 4, 2021

/retest

1 similar comment
@ashcrow
Copy link
Member

ashcrow commented May 5, 2021

/retest

@sinnykumari
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sinnykumari, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sinnykumari,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@cuppett
Copy link
Member

cuppett commented May 7, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 7, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@cuppett
Copy link
Member

cuppett commented May 10, 2021

/retest

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 10, 2021
@thegreyd
Copy link

/retest

2 similar comments
@vikaslaad
Copy link

/retest

@vikaslaad
Copy link

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@vikaslaad
Copy link

/retest

@wking
Copy link
Member

wking commented May 10, 2021

e2e-agnostic-upgrade passed all its tests, and only failed on deprovision, which is unrelated to this PR.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@wking: wking unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

e2e-agnostic-upgrade passed all its tests, and only failed on deprovision, which is unrelated to this PR.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-gcp-op 5916555 link /test okd-e2e-gcp-op
ci/prow/e2e-metal-assisted 5916555 link /test e2e-metal-assisted
ci/prow/okd-e2e-upgrade 5916555 link /test okd-e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knobunc
Copy link
Contributor

knobunc commented May 10, 2021

(stealing @wking 's justification):

e2e-agnostic-upgrade passed all its tests, and only failed on deprovision, which is unrelated to this PR.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@knobunc: knobunc unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

(stealing @wking 's justification):

e2e-agnostic-upgrade passed all its tests, and only failed on deprovision, which is unrelated to this PR.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

Given the very urgent nature of this fix, the fact that it did have a green run and that the last run (as wking pointed out) passed but failed at deprovisioning, we'll make a one time exception here and allow it to merge.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-agnostic-upgrade

In response to this:

Given the very urgent nature of this fix, the fact that it did have a green run and that the last run (as wking pointed out) passed but failed at deprovisioning, we'll make a one time exception here and allow it to merge.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e3863b0 into openshift:release-4.7 May 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1956749 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1956749: vsphere: platform none, vmxnet3v4 fix move to base

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ori-amizur added a commit to ori-amizur/assisted-service that referenced this pull request Jun 8, 2021
… OCP

This PR openshift/machine-config-operator#2564 moved the tunnel offloading patch to base and not just vsphere platform
ori-amizur added a commit to ori-amizur/assisted-service that referenced this pull request Jun 8, 2021
…done by OCP

This PR openshift/machine-config-operator#2564 moved the tunnel offloading patch to base and not just vsphere platform
openshift-merge-robot pushed a commit to openshift/assisted-service that referenced this pull request Jun 10, 2021
…done by OCP (#1955)

This PR openshift/machine-config-operator#2564 moved the tunnel offloading patch to base and not just vsphere platform
eliorerz pushed a commit to eliorerz/assisted-service that referenced this pull request Jun 27, 2021
…done by OCP (openshift#1955)

This PR openshift/machine-config-operator#2564 moved the tunnel offloading patch to base and not just vsphere platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet