New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.7] Bug 1956749: vsphere: platform none, vmxnet3v4 fix move to base #2564
[release-4.7] Bug 1956749: vsphere: platform none, vmxnet3v4 fix move to base #2564
Conversation
@openshift-cherrypick-robot: Bugzilla bug 1952358 has been cloned as Bugzilla bug 1956749. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1956749, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The template is being moved from `templates/common/vsphere` which is only applied when `platform: vsphere` is set. There are customers running `platform: none` on vSphere or ESXi directly that can be effected by the vmxnet3v4 issue.
682e723
to
5916555
Compare
/bugzilla refresh |
@jcpowermac: This pull request references Bugzilla bug 1956749, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, sinnykumari, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/bugzilla refresh |
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest |
2 similar comments
/retest |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
e2e-agnostic-upgrade passed all its tests, and only failed on deprovision, which is unrelated to this PR. /override ci/prow/e2e-agnostic-upgrade |
@wking: wking unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
(stealing @wking 's justification): e2e-agnostic-upgrade passed all its tests, and only failed on deprovision, which is unrelated to this PR. /override ci/prow/e2e-agnostic-upgrade |
@knobunc: knobunc unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Given the very urgent nature of this fix, the fact that it did have a green run and that the last run (as wking pointed out) passed but failed at deprovisioning, we'll make a one time exception here and allow it to merge. /override ci/prow/e2e-agnostic-upgrade |
@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-agnostic-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1956749 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… OCP This PR openshift/machine-config-operator#2564 moved the tunnel offloading patch to base and not just vsphere platform
…done by OCP This PR openshift/machine-config-operator#2564 moved the tunnel offloading patch to base and not just vsphere platform
…done by OCP (#1955) This PR openshift/machine-config-operator#2564 moved the tunnel offloading patch to base and not just vsphere platform
…done by OCP (openshift#1955) This PR openshift/machine-config-operator#2564 moved the tunnel offloading patch to base and not just vsphere platform
This is an automated cherry-pick of #2559
/assign cuppett