New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Alibaba Cloud provider instances with expected ProviderID #2777
Conversation
There is already an open PR for updating OpenShift libs #2772. Can you please consolidate changes into one PR and close one of them? |
@sinnykumari Thanks for looking. There is some discussion going on for #2772 currently regarding the I feel better about leaving them separate as the 2772 updates the API, library-go, and client-go which is independent of these changes. If you would prefer to join them together I can do so. |
Even this PR is updating |
@sinnykumari This is built on top of 2772 so it includes the library updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the OWNERS file for alibaba:
https://github.com/openshift/machine-config-operator/blob/master/OWNERS_ALIASES
And invoke it in your new dir like baremetal & co do: https://github.com/openshift/machine-config-operator/tree/master/templates/common/baremetal
fd3d5b7
to
6957169
Compare
@kwoodson |
just adding a hold until #2772 merges /hold |
Removing hold now since #2772 has got merged |
@rvanderp3 @fabianofranz PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little (a lot) rusty on ratcheting in a new cloud provider, but just to understand this cloud not using cloud.conf flag?
func cloudProvider(cfg RenderConfig) (interface{}, error) { |
(see 335-396)
I'd expect that this Test should also be updated:
func TestCloudProvider(t *testing.T) { |
a8c75fb
to
575de61
Compare
Thanks @kikisdeliveryservice. I've been out for a couple of days. Regarding the I rebased this PR since 2772 was merged. This removed the vendored files and reduced this down to the Alibaba specific augmentation. I have also added a test for Alibaba that should return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
waiting for final review, since you're new owners of this can you PTAL @rvanderp3 @fabianofranz? |
/lgtm |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@kikisdeliveryservice I had a team member take a look at this. Apologies for the delay we have been in training the previous week. Did you have anything else required for this PR? |
Planning to give it a final review today/tomorrow :) |
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be in good shape, thanks for your patience and hard work. Let's merge. =)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, kwoodson, rvanderp3, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@kwoodson: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
- What I did
This code enables the Alibaba Cloud provider platform on OpenShift. The Alibaba provider requires that the instances have a specific format in which the documentation states should be in
"${REGION}.${INSTANCE_ID}"
.This patch follows the pattern for other providers which sets an environment variable named
KUBELET_NODE_NAME
in/etc/systemd/system/kubelet.service.d/
. The environment variable is set through creating a service that upon start will query the metadata service for the region and the instanceid.This pull request requires #2772.
- How to verify it
I was able to verify that this code works by deploying the following work:
- Description for the changelog
Enabling support for Alibaba Cloud provider node names