[release-4.8] Bug 2011083: templates: Silence audit events from container infra by default #2793
Conversation
I was going to go add a check for "system has an AVC denial" but the problem today is that every time a container starts or stops *and* most notably liveness probes end up generating audit events. This very quickly rotates out audit events that we *do* care about. Outside of Kubernetes, workloads can be much more "static" and it makes sense for "iptables rules changed" to cause an audit event. For OpenShift, it doesn't make sense. Silence that and the promiscuous device one so that we can more easily read the audit logs captured from a CI run to verify there were no AVC denials. This will also be useful preparation for e.g. teaching the MCO do watch for some types of audit event (such as AVC) and bridge them to Prometheus metrics or so.
kikisdeliveryservice
changed the title
openshift-ci
bot
added
bugzilla/severity-urgent
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2011083, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@kikisdeliveryservice: This pull request references Bugzilla bug 2011083, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
Hey Colin, If you agree this should be backported to 4.8, please LGTM. We'll also need a BZ override as this was fixed in 4.9 without a BZ and 4.10 master already opened so I don't think we should do the BZ dance on this. /assign @cgwalters |
sdodson
added
bugzilla/valid-bug
|
Yep, this should be completely safe to backport. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh |
|
@sdodson: This pull request references Bugzilla bug 2011083, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
sdodson
added
the
cherry-pick-approved
|
/override ci/prow/e2e-azure-upgrade |
|
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-azure-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
That failure does not appear to be related to this change. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 2011083 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #2633
/assign kikisdeliveryservice