New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alibaba Cloud Provider: use --provider-id kubelet parameter #2814
Alibaba Cloud Provider: use --provider-id kubelet parameter #2814
Conversation
I added three files. I only really need the kubelet.service file. Do I need to have the other files for completeness or will they come from the I was able to get this PR working on my Alibaba cluster install. I did notice one issue though. Here is my kubelet.service file:
There is a line missing for the Thanks! |
templates/master/01-master-kubelet/alibabacloud/units/kubelet.service.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added three files. I only really need the kubelet.service file. Do I need to have the other files for completeness or will they come from the _base templates?
You should only need to add files you need. Otherwise the order of priority is:
provider > on-prem > _base
Assuming that alibabacloud counts as on-prem
templates/master/01-master-kubelet/alibabacloud/units/kubelet.service.yaml
Show resolved
Hide resolved
templates/master/01-master-kubelet/alibabacloud/files/cloudconfig.yaml
Outdated
Show resolved
Hide resolved
8f321f2
to
794e828
Compare
@yuqi-zhang I have removed the extra files as the I will test these changes and report the results. Thanks! |
@yuqi-zhang
Please let me know if there is anything else you need. |
/test e2e-agnostic-upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally lgtm, would prefer someone with more alibaba cloud knowledge to take a look as well.
Interestingly enough we split the master/worker kubelet.conf manifests but they seem to be identical. I forget if there was some reason behind it
@yuqi-zhang Thanks! Unfortunately, I'm the Alibaba guy right now. I can get another on my team or another person to TAL if that helps. cc @elmiko @rvanderp3 Either of you mind reviewing? The kubelet for control plane and for the worker are only different when it comes to node labels and taints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given what i know of alibaba, this looks correct to me
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, kwoodson, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@kwoodson: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
- What I did
Alibaba Cloud provider requires the
--provider-id
kubelet parameter instead of--hostname-override
.I added custom kubelet.service files for
alibabacloud
.- How to verify it
Install a cluster on Alibaba and verify that the control plane nodes have the proper settings in
/cat /etc/systemd/system/kubelet.service
.- Description for the changelog
AlibabaCloud provider-id kubelet flag