Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2027927: storage.conf: remove obsolete option override_kernel_check #2845

Merged
merged 1 commit into from Dec 1, 2021
Merged

Bug 2027927: storage.conf: remove obsolete option override_kernel_check #2845

merged 1 commit into from Dec 1, 2021

Conversation

frasertweedale
Copy link
Contributor

@frasertweedale frasertweedale commented Nov 30, 2021 •
edited

The storage.conf(5) override_kernel_check option was removed from the
containers/storage library in early 2019:

containers/storage@bd6cac9

With recent version of CRI-O present in OCP >= 4.9, the presence of
this field causes sandbox creation failure when using user namespaces:

Warning  FailedCreatePodSandBox  SSs (xN over MMm)  kubelet
(combined from similar events): Failed to create pod sandbox: rpc
error: code = Unknown desc = error creating pod sandbox with name
"{NAME}": error creating an ID-mapped copy of layer "{HASH}":
time="{TIMESTAMP}" level=warning msg="Failed to decode the keys
[\"storage.options.override_kernel_check\"] from
\"/etc/containers/storage.conf\"."

Remove the override_kernel_check option.

@frasertweedale
storage.conf: remove obsolete option override_kernel_check
6b83cef 
The storage.conf(5) override_kernel_check option was removed from the
containers/storage library in early 2019:

  containers/storage@bd6cac9

With recent version of CRI-O present in OCP >= 4.9, the presence of
this field causes sandbox creation failure when using user namespaces:

  Warning  FailedCreatePodSandBox  SSs (xN over MMm)  kubelet
  (combined from similar events): Failed to create pod sandbox: rpc
  error: code = Unknown desc = error creating pod sandbox with name
  "{NAME}": error creating an ID-mapped copy of layer "{HASH}":
  time="{TIMESTAMP}" level=warning msg="Failed to decode the keys
  [\"storage.options.override_kernel_check\"] from
  \"/etc/containers/storage.conf\"."

Remove the override_kernel_check option.

Signed-off-by: Fraser Tweedale <ftweedal@redhat.com>
@frasertweedale
Copy link
Contributor Author

/cherry-pick release-4.9

@openshift-cherrypick-robot
Copy link

@frasertweedale: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frasertweedale
Copy link
Contributor Author

/retest

@sinnykumari
Copy link
Contributor

/cc @umohnani8 @mrunalp

@frasertweedale
Copy link
Contributor Author

/cc @giuseppe

@openshift-ci openshift-ci bot requested a review from giuseppe November 30, 2021 11:16
giuseppe
giuseppe approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frasertweedale
Copy link
Contributor Author

/assign @kikisdeliveryservice

@frasertweedale
Copy link
Contributor Author

/retest

@kikisdeliveryservice
Copy link
Contributor

@haircommander can you PTAL?

@haircommander
Copy link
Member

/lgtm

makes sense to me!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frasertweedale, giuseppe, haircommander, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021 •
edited

@frasertweedale: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 6b83cef link false /test e2e-aws-single-node
ci/prow/okd-e2e-aws 6b83cef link false /test okd-e2e-aws
ci/prow/e2e-aws-upgrade-single-node 6b83cef link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-workers-rhel7 6b83cef link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-disruptive 6b83cef link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 41677e7 into openshift:master Dec 1, 2021
@frasertweedale frasertweedale deleted the fix/rm-bad-storage.conf-field branch December 1, 2021 03:52
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 1, 2021
Merged
@openshift-cherrypick-robot
Copy link

@frasertweedale: new pull request created: #2848

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frasertweedale
Copy link
Contributor Author

/retitle Bug 2027927: storage.conf: remove obsolete option override_kernel_check

@openshift-ci openshift-ci bot changed the title storage.conf: remove obsolete option override_kernel_check Bug 2027927: storage.conf: remove obsolete option override_kernel_check Dec 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021

@frasertweedale: All pull requests linked via external trackers have merged:

Bugzilla bug 2027927 has been moved to the MODIFIED state.

In response to this:

Bug 2027927: storage.conf: remove obsolete option override_kernel_check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frasertweedale
Copy link
Contributor Author

/bugzilla cc-qa

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021

@frasertweedale: Bugzilla bug 2027927 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Member

/cherry-pick release-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 21, 2022
Merged
@openshift-cherrypick-robot
Copy link

@QiWang19: new pull request created: #3259

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@mrunalp mrunalp Awaiting requested review from mrunalp

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@kikisdeliveryservice kikisdeliveryservice

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@frasertweedale @openshift-cherrypick-robot @sinnykumari @kikisdeliveryservice @haircommander @openshift-bot @QiWang19 @giuseppe @openshift-merge-robot