[release-4.9] Bug 2027926: storage.conf: remove obsolete option override_kernel_check #2848

openshift-cherrypick-robot · 2021-12-01T03:52:26Z

This is an automated cherry-pick of #2845

/assign frasertweedale

The storage.conf(5) override_kernel_check option was removed from the containers/storage library in early 2019: containers/storage@bd6cac9 With recent version of CRI-O present in OCP >= 4.9, the presence of this field causes sandbox creation failure when using user namespaces: Warning FailedCreatePodSandBox SSs (xN over MMm) kubelet (combined from similar events): Failed to create pod sandbox: rpc error: code = Unknown desc = error creating pod sandbox with name "{NAME}": error creating an ID-mapped copy of layer "{HASH}": time="{TIMESTAMP}" level=warning msg="Failed to decode the keys [\"storage.options.override_kernel_check\"] from \"/etc/containers/storage.conf\"." Remove the override_kernel_check option. Signed-off-by: Fraser Tweedale <ftweedal@redhat.com>

frasertweedale · 2021-12-01T04:23:45Z

/retitle [release-4.9] Bug 2027926: storage.conf: remove obsolete option override_kernel_check

openshift-ci · 2021-12-01T04:23:49Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2027926, which is invalid:

expected the bug to target the "4.9.z" release, but it targets "---" instead
expected Bugzilla bug 2027926 to depend on a bug targeting a release in 4.10.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2027926: storage.conf: remove obsolete option override_kernel_check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2021-12-01T14:50:52Z

/lgtm

frasertweedale · 2021-12-02T00:52:51Z

/assign @yuqi-zhang

openshift-bot · 2021-12-02T01:00:32Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-12-02T01:00:36Z

@openshift-bot: This pull request references Bugzilla bug 2027926, which is invalid:

expected dependent Bugzilla bug 2027927 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frasertweedale · 2021-12-02T10:38:50Z

/retest-required

sinnykumari · 2021-12-02T10:51:40Z

/skip

openshift-ci · 2021-12-02T10:52:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sinnykumari · 2021-12-02T10:53:51Z

Please reach out to @umohnani8 and corresponding QE taking care of container runtime related changes in MCO for backport-risk-assessed and cherry-pick approved label being applied.

openshift-bot · 2021-12-02T13:13:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-02T15:30:29Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-02T17:50:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-12-02T19:55:47Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-gcp-op	`1d75b96`	link	false	`/test okd-e2e-gcp-op`
ci/prow/e2e-aws-workers-rhel7	`1d75b96`	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-aws-upgrade-single-node	`1d75b96`	link	false	`/test e2e-aws-upgrade-single-node`
ci/prow/e2e-aws-disruptive	`1d75b96`	link	false	`/test e2e-aws-disruptive`
ci/prow/okd-e2e-upgrade	`1d75b96`	link	false	`/test okd-e2e-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kikisdeliveryservice · 2021-12-02T21:20:30Z

let's hold until other bug is validated to save ci runs and notifications :)

/backport-risk-assessed
/hold

frasertweedale · 2021-12-09T11:50:22Z

/bugzilla refresh

openshift-ci · 2021-12-09T11:50:30Z

@frasertweedale: This pull request references Bugzilla bug 2027926, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2027927 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2027927 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frasertweedale · 2021-12-10T02:25:35Z

@sunilcio @umohnani8 could you please take a look and, if satisfied, add the backport-risk-assessed and cherry-pick-approved labels?

umohnani8 · 2021-12-10T16:12:50Z

yup, LGTM

frasertweedale · 2021-12-13T03:15:39Z

/retest

sunilcio · 2021-12-14T03:36:20Z

/label qe-approved

sinnykumari · 2021-12-14T09:35:20Z

@sunilcio You need to add cherry-pick-approved label. This is now applied by respective QE team member and you are already been added openshift/release#23197

sunilcio · 2021-12-14T12:53:14Z

/label cherry-pick-approved

sinnykumari · 2021-12-15T13:51:07Z

PR has all the required label, hold no longer needed.
/hold cancel

openshift-ci · 2021-12-15T13:56:20Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2848

Bugzilla bug 2027926 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2027926: storage.conf: remove obsolete option override_kernel_check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Dec 1, 2021

Bug 2027927: storage.conf: remove obsolete option override_kernel_check #2845

Merged

openshift-ci bot assigned frasertweedale Dec 1, 2021

openshift-ci bot requested review from kikisdeliveryservice and yuqi-zhang December 1, 2021 03:52

openshift-ci bot changed the title ~~[release-4.9] storage.conf: remove obsolete option override_kernel_check~~ [release-4.9] Bug 2027926: storage.conf: remove obsolete option override_kernel_check Dec 1, 2021

openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 1, 2021

openshift-ci bot assigned haircommander Dec 1, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021

openshift-ci bot assigned yuqi-zhang Dec 2, 2021

openshift-ci bot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Dec 2, 2021

openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Dec 2, 2021

sinnykumari approved these changes Dec 2, 2021

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 9, 2021

sinnykumari added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 13, 2021

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 14, 2021

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 14, 2021

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2021

openshift-merge-robot merged commit 23d93af into openshift:release-4.9 Dec 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.9] Bug 2027926: storage.conf: remove obsolete option override_kernel_check #2848

[release-4.9] Bug 2027926: storage.conf: remove obsolete option override_kernel_check #2848

openshift-cherrypick-robot commented Dec 1, 2021

frasertweedale commented Dec 1, 2021

openshift-ci bot commented Dec 1, 2021

haircommander commented Dec 1, 2021

frasertweedale commented Dec 2, 2021

openshift-bot commented Dec 2, 2021

openshift-ci bot commented Dec 2, 2021

frasertweedale commented Dec 2, 2021

sinnykumari commented Dec 2, 2021

openshift-ci bot commented Dec 2, 2021

sinnykumari commented Dec 2, 2021

openshift-bot commented Dec 2, 2021

openshift-bot commented Dec 2, 2021

openshift-bot commented Dec 2, 2021

openshift-ci bot commented Dec 2, 2021 •

edited

kikisdeliveryservice commented Dec 2, 2021

frasertweedale commented Dec 9, 2021

openshift-ci bot commented Dec 9, 2021

frasertweedale commented Dec 10, 2021

umohnani8 commented Dec 10, 2021

frasertweedale commented Dec 13, 2021

sunilcio commented Dec 14, 2021

sinnykumari commented Dec 14, 2021

sunilcio commented Dec 14, 2021

sinnykumari commented Dec 15, 2021

openshift-ci bot commented Dec 15, 2021

[release-4.9] Bug 2027926: storage.conf: remove obsolete option override_kernel_check #2848

[release-4.9] Bug 2027926: storage.conf: remove obsolete option override_kernel_check #2848

Conversation

openshift-cherrypick-robot commented Dec 1, 2021

frasertweedale commented Dec 1, 2021

openshift-ci bot commented Dec 1, 2021

haircommander commented Dec 1, 2021

frasertweedale commented Dec 2, 2021

openshift-bot commented Dec 2, 2021

openshift-ci bot commented Dec 2, 2021

frasertweedale commented Dec 2, 2021

sinnykumari commented Dec 2, 2021

openshift-ci bot commented Dec 2, 2021

sinnykumari commented Dec 2, 2021

openshift-bot commented Dec 2, 2021

openshift-bot commented Dec 2, 2021

openshift-bot commented Dec 2, 2021

openshift-ci bot commented Dec 2, 2021 • edited

kikisdeliveryservice commented Dec 2, 2021

frasertweedale commented Dec 9, 2021

openshift-ci bot commented Dec 9, 2021

frasertweedale commented Dec 10, 2021

umohnani8 commented Dec 10, 2021

frasertweedale commented Dec 13, 2021

sunilcio commented Dec 14, 2021

sinnykumari commented Dec 14, 2021

sunilcio commented Dec 14, 2021

sinnykumari commented Dec 15, 2021

openshift-ci bot commented Dec 15, 2021

openshift-ci bot commented Dec 2, 2021 •

edited