Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2046683: Ensure correct providerID format for Alibaba nodes #2931

Merged
merged 1 commit into from Jan 27, 2022

Conversation

JoelSpeed
Copy link
Contributor

- What I did

This adds the alicloud:// prefix to the provider ID that we set on the alibaba kubelet service.

This ensures that the provider ID on the nodes includes the expected prefix and matches the provider ID format used in other places (eg Machine API).

I've manually tested this and check with @gujingit that this is supported by the Alibaba CCM

- How to verify it

Boot a cluster on Alibaba and check the node.spec.providerID has the alicloud:// prefix

- Description for the changelog

Fix Alibaba providerID to include alicloud prefix

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

@JoelSpeed: This pull request references Bugzilla bug 2046683, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 2046683: Ensure correct providerID format for Alibaba nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gujingit
Copy link

Alibaba CCM has already supported the alicloud prefix, it's ok to change the node provider ID. Thanks.
https://github.com/kubernetes/cloud-provider-alibaba-cloud/blob/ef08fd22df7dc602d684827d06381ad6767ebebe/pkg/provider/alibaba/util/helper.go#L42

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 705d182 link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi 705d182 link false /test e2e-metal-ipi
ci/prow/e2e-aws-workers-rhel7 705d182 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-gcp-op-single-node 705d182 link false /test e2e-gcp-op-single-node
ci/prow/e2e-aws-single-node 705d182 link false /test e2e-aws-single-node
ci/prow/e2e-aws-workers-rhel8 705d182 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-serial 705d182 link false /test e2e-aws-serial
ci/prow/e2e-aws-upgrade-single-node 705d182 link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-vsphere-upgrade 705d182 link false /test e2e-vsphere-upgrade
ci/prow/okd-e2e-aws 705d182 link false /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@@ -39,7 +39,7 @@ contents: |
--cloud-provider={{cloudProvider .}} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tangentially related, the forking of the kubelet unit is definitely out of control now 😢

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, elmiko, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit 47436bd into openshift:master Jan 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

@JoelSpeed: All pull requests linked via external trackers have merged:

Bugzilla bug 2046683 has been moved to the MODIFIED state.

In response to this:

Bug 2046683: Ensure correct providerID format for Alibaba nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed JoelSpeed deleted the ali-provider-id branch January 27, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants