New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2046683: Ensure correct providerID format for Alibaba nodes #2931
Bug 2046683: Ensure correct providerID format for Alibaba nodes #2931
Conversation
@JoelSpeed: This pull request references Bugzilla bug 2046683, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Alibaba CCM has already supported the alicloud prefix, it's ok to change the node provider ID. Thanks. |
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes sense to me
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@@ -39,7 +39,7 @@ contents: | | |||
--cloud-provider={{cloudProvider .}} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tangentially related, the forking of the kubelet unit is definitely out of control now 😢
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, elmiko, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed: All pull requests linked via external trackers have merged: Bugzilla bug 2046683 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- What I did
This adds the
alicloud://
prefix to the provider ID that we set on the alibaba kubelet service.This ensures that the provider ID on the nodes includes the expected prefix and matches the provider ID format used in other places (eg Machine API).
I've manually tested this and check with @gujingit that this is supported by the Alibaba CCM
- How to verify it
Boot a cluster on Alibaba and check the
node.spec.providerID
has thealicloud://
prefix- Description for the changelog
Fix Alibaba providerID to include
alicloud
prefix