Bug 2078945: Ensure only one apiserver-watcher process is active on a node.

[sanchezl]

- What I did

An alternative of #2674, using flock.

- Description for the changelog

wrap apiserver-watcher call with flock.

[kikisdeliveryservice]

ill add a hold to both PRs and yall can let me know which one you want to go with.

/hold
/assign @deads2k @squeed @aojea

[sanchezl]

/retest

[squeed]

@sanchezl cute :). Can you file a WIP "backport" pr on 4.10? Would you expect it to work?

[cgwalters]

/approve

[aojea]

lgtm

defer to @squeed the final decision, but this seems simpler and easier to backport

[squeed]

Let's do this one. Feel free to un-hold. Thanks!

[squeed]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, sanchezl, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aojea]

/hold cancel

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@sanchezl: This pull request references Bugzilla bug 1948551, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 1948551: apiserver-watcher: prevent concurrent executions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sanchezl]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@sanchezl: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sanchezl]

/hold
while I get things straight in BZ

[openshift-ci]

@sanchezl: This pull request references Bugzilla bug 2078945, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 2078945: Ensure only one apiserver-watcher process is active on a node.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sanchezl]

/hold cancel

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@sanchezl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@sanchezl: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#3106

Bugzilla bug 2078945 has been moved to the MODIFIED state.

In response to this:

Bug 2078945: Ensure only one apiserver-watcher process is active on a node.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@sanchezl: new pull request created: #3121

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.