Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1948551: apiserver-watcher should run in a privileged namespace #3107

Merged
merged 1 commit into from May 25, 2022
Merged

Bug 1948551: apiserver-watcher should run in a privileged namespace #3107

merged 1 commit into from May 25, 2022

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Apr 22, 2022 •
edited

Move the apiserver-watcher static pods from the kube-system namespace to the openshift-kube-apiserver namespace.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sanchezl
Copy link
Contributor Author

/test all

@aojea
Copy link
Contributor

aojea commented Apr 26, 2022

/assign @kikisdeliveryservice @aojea

@aojea
Copy link
Contributor

aojea commented Apr 26, 2022

/test e2e-agnostic-upgrade

@sanchezl sanchezl marked this pull request as ready for review April 26, 2022 14:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2022
@openshift-ci openshift-ci bot requested a review from sinnykumari April 26, 2022 14:44
@sanchezl
Copy link
Contributor Author

/hold
for backport of #3106 to make it into 4.10.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2022
@sanchezl sanchezl changed the title move apiserver-watcher pod out of kube-system Bug 1948551: apiserver-watcher should run in a privileged namespace Apr 26, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Apr 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2022

@sanchezl: This pull request references Bugzilla bug 1948551, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 1948551: apiserver-watcher should run in a privileged namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 26, 2022
@openshift-ci openshift-ci bot requested a review from wangke19 April 26, 2022 14:47
@aojea
Copy link
Contributor

aojea commented Apr 26, 2022

the flock should merge first, no?

@sanchezl
Copy link
Contributor Author

the flock should merge first, no?

Yes. In addition to the /hold, I will be configuring the appropriate dependent bugs in BZ.

@sanchezl
Copy link
Contributor Author

sanchezl commented May 9, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2022
@sanchezl
Copy link
Contributor Author

sanchezl commented May 9, 2022

/retest

@sinnykumari
Copy link
Contributor

/cc @sttts , PTAL

@sinnykumari
Copy link
Contributor

/assign @sttts

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

Confirmed that namespace is privileged:

apiVersion: v1
kind: Namespace
metadata:
  name: openshift-kube-apiserver
  labels:
    pod-security.kubernetes.io/audit: privileged
    pod-security.kubernetes.io/enforce: privileged
    pod-security.kubernetes.io/warn: privileged

@squeed squeed mentioned this pull request May 18, 2022
Closed
@squeed
Copy link
Contributor

squeed commented May 18, 2022

/test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

1 similar comment
@sanchezl
Copy link
Contributor Author

/test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

@squeed
Copy link
Contributor

squeed commented May 24, 2022

The upgrade test looks good; it's just that weird telemeter test that seems problematic.

@squeed
Copy link
Contributor

squeed commented May 24, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@sanchezl
Copy link
Contributor Author

openshift/cincinnati-graph-data#1909 has merged. It should be safe to merge this PR now.

@tkashem
Copy link

tkashem commented May 24, 2022

/lgtm

sinnykumari
sinnykumari approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as apiserver team has reviewed the PR and tests are passing

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanchezl, sinnykumari, squeed, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2022 •
edited

@sanchezl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade 0a0e529 link false /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b52e75e into openshift:master May 25, 2022
7 of 8 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2022

@sanchezl: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1948551 has not been moved to the MODIFIED state.

In response to this:

Bug 1948551: apiserver-watcher should run in a privileged namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinnykumari sinnykumari sinnykumari approved these changes

@jkyros jkyros Awaiting requested review from jkyros

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@squeed squeed

@sttts sttts

@kikisdeliveryservice kikisdeliveryservice

@aojea aojea

@tkashem tkashem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@sanchezl @aojea @sinnykumari @squeed @tkashem @openshift-bot @sttts @kikisdeliveryservice @openshift-merge-robot