[release-4.10] Bug 2089757: configure-ovs: avoid restarting NetworkManager #3159
Conversation
|
/cherry-pick release-4.9 |
openshift-ci
bot
added
the
bugzilla/severity-urgent
|
@jcaamano: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/invalid-bug
|
@jcaamano: This pull request references Bugzilla bug 2089757, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
general sanity check seems fine. I see this also brings in a few bits from jcaamano@ebf1072
Which is I guess why you had to manually cherry pick?
I see this also removes the changes in #3154. Should that PR be consolidated?
Yup, I picked a couple of things from there.
Yup, that's a good idea. I will. |
|
/test ? |
|
@jcaamano: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test 4.10-upgrade-from-stable-4.9-e2e-aws-ovn-upgrade |
|
/test e2e-aws-ovn-workers-rhel8 |
|
/lgtm Nit: can you change the commit message to add or something else to indicate that this is not a clean bp (for future time travelers)? The conflicts that I found are minor and are around:
|
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
openshift-ci
bot
added
bugzilla/valid-bug
|
@openshift-bot: This pull request references Bugzilla bug 2089757, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Conflicts: templates/common/_base/files/configure-ovs-network.yaml Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com> (cherry picked from commit cc8a2c5)
|
/test 4.10-upgrade-from-stable-4.9-e2e-aws-ovn-upgrade |
|
/lgtm |
|
testing if lgtm applies approval now |
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreaskaris, jcaamano, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Needs cherry-pick approval |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/retest-required |
|
@sinnykumari we may need an override on the e2e-agnostic-upgrade jobs, it's been failing for a while. |
|
/skip |
|
Checking if upgrade passes at least on one of the platform |
|
Both e2e-aws-upgrade and e2e-gcp-upgrade test passed on this PR. Overriding flaky e2e-agnostic-upgrade test(runs on Azure) test so that this important fix can get merged. |
|
@sinnykumari: Overrode contexts on behalf of sinnykumari: ci/prow/e2e-agnostic-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jcaamano: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Skip optional tests |
openshift-merge-robot
merged commit 7152adb
into
openshift:release-4.10
|
@jcaamano: All pull requests linked via external trackers have merged: Bugzilla bug 2089757 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jcaamano: #3159 failed to apply on top of branch "release-4.9": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry-pick of #3120 c6c9288
Signed-off-by: Jaime Caamaño Ruiz jcaamano@redhat.com
(cherry picked from commit cc8a2c5)
- What I did
- How to verify it
- Description for the changelog