Bug 2089687: Update alert message for drain failure #3169
Conversation
Update message to point to MCC and not MCD pod, since MCC now does the actual draining. For now we are doing this to preserve old alerts, but we should potentially consider alerting via MCC and deprecating the old alert.
openshift-ci
bot
added
bugzilla/severity-unspecified
|
@yuqi-zhang: This pull request references Bugzilla bug 2089687, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (rioliu@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sinnykumari, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-agnostic-upgrade |
|
@yuqi-zhang: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@yuqi-zhang: All pull requests linked via external trackers have merged: Bugzilla bug 2089687 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ls for MCC logs Avoiding the machine-config-controller-xxxxx from c90d7e4 (Update alert message for drain failure, 2022-05-30, openshift#3169), so users don't need to manually replace a pod-name placeholder. Moving to a label selector also automatically gets us --tail=10 limiting, so we aren't flooded by old history: $ oc logs --help | grep -A1 tail --tail=-1: Lines of recent log file to display. Defaults to -1 with no selector, showing all log lines otherwise 10, if a selector is provided. That limiting might remove older 'Cannot evict pod ...' messages, but the -f/--follow means that if there's still a problem, we'll get a fresh log complaining about it soon.
Update message to point to MCC and not MCD pod, since MCC now does
the actual draining.
For now we are doing this to preserve old alerts, but we should
potentially consider alerting via MCC and deprecating the old alert.