Bug 2105082: 4.7: daemon: Explicitly start rpm-ostreed, restart if we detect active txn #3240
Conversation
|
@cgwalters: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@cgwalters: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cgwalters
changed the title
openshift-ci
bot
added
bugzilla/severity-medium
|
@cgwalters: This pull request references Bugzilla bug 2057544, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
cgwalters
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
@cgwalters: This pull request references Bugzilla bug 2105082, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@cgwalters: This pull request references Bugzilla bug 2105082, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| // Synchronously invoke rpm-ostree, writing its stdout to our stdout, | ||
| // and gathering stderr into a buffer which will be returned in err | ||
| // in case of error. | ||
| func runRpmOstree(args ...string) error { |
There was a problem hiding this comment.
I think we will also need to update Rebase() to call runRpmOstree()
There was a problem hiding this comment.
Good observation! Thinking about this a bit though, the key thing in this change is that we're invoking the Initialize() method early on. runRpmOstree is just a wrapper that uses the cleaned up subprocess handling in runCmdSync - but it doesn't actually have any of the new special rpm-ostree logic itself.
So while I think you're correct in that this change better matches what lives on master with that suggestion, I don't think it's actually required either.
But regardless - updated!
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
This is a workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1982389 which is already fixed in rpm-ostree in coreos/rpm-ostree#2995 because it will take a fair while until we can ship the fixed rpm-ostreed in RHEL and then OpenShift stable versions. (Yes, this is a sad recurring pattern) The updater client gains an explicit `Initialize` method, where we also explicitly `systemctl start rpm-ostreed` which then effectively rolls in the change from coreos/rpm-ostree#2945 too.
cgwalters
force-pushed
the
rpmostree-workaround-4.7
branch
from
7d9933a
to
6894d9b
Compare
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit 54116a9
into
openshift:release-4.7
|
@cgwalters: All pull requests linked via external trackers have merged: Bugzilla bug 2105082 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual backport since auto-cherry pick failed:
#2967 (comment)
This is a workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1982389
which is already fixed in rpm-ostree in
coreos/rpm-ostree#2995
because it will take a fair while until we can ship the fixed
rpm-ostreed in RHEL and then OpenShift stable versions.
(Yes, this is a sad recurring pattern)
The updater client gains an explicit
Initializemethod, wherewe also explicitly
systemctl start rpm-ostreedwhichthen effectively rolls in the change from
coreos/rpm-ostree#2945
too.