Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-13138: daemon: Don't traverse /run/ostree/auth.json symlink #3697

Merged
merged 1 commit into from May 23, 2023
Merged

[release-4.13] OCPBUGS-13138: daemon: Don't traverse /run/ostree/auth.json symlink #3697

merged 1 commit into from May 23, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3691

/assign cgwalters

@cgwalters
OCPBUGS-12951: daemon: Don't traverse /run/ostree/auth.json symlink
819069f 
In the case that we've already written the link, but there
is no `/var/lib/kubelet/config.json`, we will try to re-create
the link and fail.

I believe this can happen in the assisted installer path, and
only if we end up re-trying an initialization.

https://issues.redhat.com/browse/OCPBUGS-12951
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 4, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-12951 has been cloned as Jira Issue OCPBUGS-13138. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-13138: daemon: Don't traverse /run/ostree/auth.json symlink

In response to this:

This is an automated cherry-pick of #3691

/assign cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-12951: daemon: Don't traverse /run/ostree/auth.json symlink [release-4.13] OCPBUGS-13138: daemon: Don't traverse /run/ostree/auth.json symlink May 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] OCPBUGS-13138: daemon: Don't traverse /run/ostree/auth.json symlink

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 4, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-13138, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-12951 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-12951 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #3691

/assign cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari
Copy link
Contributor

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 16, 2023
@sinnykumari
Copy link
Contributor

For cherry-pick approval
/cc @sergiordlr

@sinnykumari
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2023
@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label May 16, 2023
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 19, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 230bb7e and 2 for PR HEAD 819069f in total

@sdodson
Copy link
Member

sdodson commented May 19, 2023

/test e2e-gcp-op

@sdodson
Copy link
Member

sdodson commented May 19, 2023

/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-rt 819069f link false /test e2e-gcp-rt
ci/prow/okd-scos-e2e-vsphere-ovn 819069f link false /test okd-scos-e2e-vsphere-ovn
ci/prow/e2e-hypershift 819069f link false /test e2e-hypershift
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 819069f link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-rt-op 819069f link false /test e2e-gcp-rt-op
ci/prow/e2e-alibabacloud-ovn 819069f link false /test e2e-alibabacloud-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented May 23, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 1ae3805 into openshift:release-4.13 May 23, 2023
19 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-13138: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13138 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #3691

/assign cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

/cherrypick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 25, 2023
Merged
@openshift-cherrypick-robot
Copy link
Author

@cgwalters: new pull request created: #3818

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

@cgwalters cgwalters Awaiting requested review from cgwalters

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@cgwalters cgwalters

@rbbratta rbbratta

@eurijon eurijon

@mburman5 mburman5

@reihl reihl

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet