New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-references: Update maipo oscontainer #404

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
6 participants
@cgwalters
Copy link
Contributor

cgwalters commented Feb 11, 2019

This isn't the long term path, but let's do this until
we have that implemented.

image-references: Update maipo oscontainer
This isn't the long term path, but let's do this until
we have that implemented.
@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 11, 2019

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 11, 2019

aws_route_table_association.route_net.1: timeout while waiting for state to become 'success'

/test e2e-aws

@jlebon

This comment has been minimized.

Copy link
Member

jlebon commented Feb 11, 2019

Can we add the corresponding OS version as a comment there?

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 11, 2019

/flake

/test e2e-aws

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 11, 2019

Different flake ...

/test e2e-aws

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 11, 2019

/test e2e-aws

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5656913 into openshift:master Feb 12, 2019

6 checks passed

ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-op Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/rhel-images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
tide In merge pool.
Details
@cgwalters

This comment has been minimized.

Copy link
Contributor Author

cgwalters commented Feb 12, 2019

For reference I was confused about how things work; the images referenced here are basically never really used...we should probably replace them with dummy values now.

The source of truth (AIUI) is the imagestreams maintained at api.ci which feed into the release controller, which uses them to update the release payload's machine-os-content and oc adm release new will use that digested pull spec and replace the value here.

openshift/origin#21998 was trying to do this a different way but for now we're going to do some manual tagging.

jlebon added a commit to jlebon/machine-config-operator that referenced this pull request Feb 14, 2019

Match image reference in osimageurl configmap
Minor regression from openshift#404. For the substitution to take place, the
pullspec has to match exactly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment