New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: Write out pending state file just before reboot #405

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
5 participants
@cgwalters
Copy link
Contributor

cgwalters commented Feb 11, 2019

Saw

E0211 21:20:54.783163   68957 daemon.go:384] Fatal error checking initial state of node: Checking initial state: pending config master-e36ac826fbfdf3342e5579460c64658e bootID 4f94db9f-79a2-43be-8630-4fb276eb2e14 matches current! Failed to reboot?
E0211 21:20:54.783186   68957 writer.go:91] Marking degraded due to: Checking initial state: pending config master-e36ac826fbfdf3342e5579460c64658e bootID 4f94db9f-79a2-43be-8630-4fb276eb2e14 matches current! Failed to reboot?

on chat. Thinking about this, we could hit this case if e.g.
the MCD was restarted during the drain (or more generally between
where we were writing the pending file and rebooting).

Let's write it just before reboot to reduce the chance of hitting
those cases.

daemon: Write out pending state file just before reboot
Saw
```
E0211 21:20:54.783163   68957 daemon.go:384] Fatal error checking initial state of node: Checking initial state: pending config master-e36ac826fbfdf3342e5579460c64658e bootID 4f94db9f-79a2-43be-8630-4fb276eb2e14 matches current! Failed to reboot?
E0211 21:20:54.783186   68957 writer.go:91] Marking degraded due to: Checking initial state: pending config master-e36ac826fbfdf3342e5579460c64658e bootID 4f94db9f-79a2-43be-8630-4fb276eb2e14 matches current! Failed to reboot?
```
on chat.  Thinking about this, we could hit this case if e.g.
the MCD was restarted during the drain (or more generally between
where we were writing the pending file and rebooting).

Let's write it just before reboot to reduce the chance of hitting
those cases.
@runcom

This comment has been minimized.

Copy link
Member

runcom commented Feb 11, 2019

/approve

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 11, 2019

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ashcrow,cgwalters,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 11, 2019

/flake

aws_route_table_association.route_net.5: timeout while waiting for state to become 'success' 

/test e2e-aws

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 11, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit e494909 into openshift:master Feb 12, 2019

6 checks passed

ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-op Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/rhel-images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment