Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure platform #602

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
8 participants
@awesomenix
Copy link

awesomenix commented Apr 4, 2019

- What I did

Add support for Azure platform

- How to verify it

installer will add support for azure platform soon.

- Description for the changelog
Add support for Azure platform

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Apr 4, 2019

Hi @awesomenix. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awesomenix

This comment has been minimized.

Copy link
Author

awesomenix commented Apr 4, 2019

/assign @enxebre

Nishchay Kumar

@awesomenix awesomenix force-pushed the awesomenix:master branch from 3b6b972 to 9d99eec Apr 4, 2019

@enxebre

This comment has been minimized.

Copy link
Member

enxebre commented Apr 4, 2019

/ok-to-test

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Apr 4, 2019

does this need an exception? is there an existing installer pr (if so please link it)

/hold

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Apr 4, 2019

afaik this is for a future release.

@awesomenix

This comment has been minimized.

Copy link
Author

awesomenix commented Apr 4, 2019

@awesomenix

This comment has been minimized.

Copy link
Author

awesomenix commented Apr 10, 2019

@kikisdeliveryservice @enxebre can this be merged please, all other operators have support for azure platform except for this one, are there additional gates for this operator?

@enxebre

This comment has been minimized.

Copy link
Member

enxebre commented Apr 10, 2019

this is part of an effort for upcoming Azure support
https://github.com/openshift/installer/pull/1534/files
https://github.com/openshift/cluster-api-provider-azure
One of the repo owners should validate this PR doesn't suppose any risk for 4.1, otherwise
/lgtm

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Apr 10, 2019

RHCOS isn't slated to support Azure in this release and given how important the MCO, I'd much rather hold any new feature until a future release as planned.
Happy to review later.

@runcom

This comment has been minimized.

Copy link
Member

runcom commented Apr 10, 2019

This has a (almsot) 0.000% chance of breaking anything here as these if(s) are gonna be gated anyway.

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Apr 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awesomenix, enxebre, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Apr 10, 2019

This has a (almsot) 0.000% chance of breaking anything here as these if(s) are gonna be gated anyway.

That's likely the case, but in terms of process, was the change approved to be merged into the installer?

@runcom

This comment has been minimized.

Copy link
Member

runcom commented Apr 10, 2019

/hold cancel

@crawford

This comment has been minimized.

Copy link
Member

crawford commented Apr 10, 2019

Azure-related PRs are approved to be merged as long as they impose very little risk on the project. I agree with @runcom that this is extremely unlikely to break existing functionality, so this can be merged. Sorry for the surprise. I forgot we had to make any changes to the MCO.

@openshift-merge-robot openshift-merge-robot merged commit 68bfae4 into openshift:master Apr 10, 2019

6 checks passed

ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-op Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
ci/prow/verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.