Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/daemon: allow skip reboot in onceFrom MCD #635

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
6 participants
@runcom
Copy link
Member

runcom commented Apr 12, 2019

This patch introduces a new --skip-reboot flag (defaulting to false) and
only honored in onceFrom mode (e.g. dn.onceFrom != ""). This is a
requirement for BYOH team and the Ansible integration.

Signed-off-by: Antonio Murdaca runcom@linux.com

@runcom runcom force-pushed the runcom:skip-reboot-mcd branch from 11c8f1c to e5f4dc4 Apr 12, 2019

@openshift-ci-robot openshift-ci-robot added size/M and removed size/S labels Apr 12, 2019

@runcom runcom force-pushed the runcom:skip-reboot-mcd branch from e5f4dc4 to 936029d Apr 12, 2019

@ashcrow
Copy link
Member

ashcrow left a comment

LGTM

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Apr 12, 2019

/lgtm

@runcom

This comment has been minimized.

Copy link
Member Author

runcom commented Apr 12, 2019

/lgtm

putting an hold just til BYOH team reports back that this does work (I'll lift the hold and lgtm should still apply)

/hold

@runcom

This comment has been minimized.

Copy link
Member Author

runcom commented Apr 12, 2019

/retest

1 similar comment
@runcom

This comment has been minimized.

Copy link
Member Author

runcom commented Apr 13, 2019

/retest

pkg/daemon: allow skip reboot in onceFrom MCD
This patch introduces a new --skip-reboot flag (defaulting to false) and
only honored in onceFrom mode (e.g. dn.onceFrom != ""). This is a
requirement for BYOH team and the Ansible integration.

Signed-off-by: Antonio Murdaca <runcom@linux.com>

@runcom runcom force-pushed the runcom:skip-reboot-mcd branch from 936029d to 83b1305 Apr 15, 2019

@runcom

This comment has been minimized.

Copy link
Member Author

runcom commented Apr 15, 2019

New changes are detected. LGTM label has been removed.

repushed by just amending commit for BYOH team tests

@mtnbikenc

This comment has been minimized.

Copy link
Member

mtnbikenc commented Apr 15, 2019

BYOH scaleup tested successfully. Nice task output and Ansible was able to control the reboot.
Tested with openshift/openshift-ansible#11493

    I0415 14:19:16.300487       1 start.go:56] Version: 4.0.0-alpha.0-194-g1d6c0e6b-dirty
    I0415 14:19:16.300988       1 start.go:89] Starting node writer
    I0415 14:19:16.301020       1 start.go:96] Cannot initialize ClientBuilder, likely in onceFrom mode with Ignition
    I0415 14:19:16.301073       1 start.go:178] Calling chroot("/rootfs")
    I0415 14:19:16.301085       1 start.go:188] Starting MachineConfigDaemon
    I0415 14:19:16.301098       1 daemon.go:479] Enabling Kubelet Healthz Monitor
    I0415 14:19:16.398879       1 update.go:601] Writing file "/etc/tmpfiles.d/cleanup-cni.conf"
    I0415 14:19:16.401559       1 update.go:601] Writing file "/etc/systemd/system.conf.d/kubelet-cgroups.conf"
    I0415 14:19:16.403296       1 update.go:601] Writing file "/var/lib/kubelet/config.json"
    I0415 14:19:16.405363       1 update.go:601] Writing file "/etc/kubernetes/ca.crt"
    I0415 14:19:16.407071       1 update.go:601] Writing file "/etc/sysctl.d/forward.conf"
    I0415 14:19:16.408463       1 update.go:601] Writing file "/etc/kubernetes/kubelet-plugins/volume/exec/.dummy"
    I0415 14:19:16.409409       1 update.go:601] Writing file "/etc/containers/registries.conf"
    I0415 14:19:16.411022       1 update.go:601] Writing file "/etc/containers/storage.conf"
    I0415 14:19:16.412588       1 update.go:601] Writing file "/etc/crio/crio.conf"
    I0415 14:19:16.414724       1 update.go:601] Writing file "/etc/kubernetes/kubelet.conf"
    I0415 14:19:16.416132       1 update.go:601] Writing file "/etc/machine-config-daemon/node-annotations.json"
    I0415 14:19:16.417727       1 update.go:601] Writing file "/etc/pivot/image-pullspec"
    I0415 14:19:16.419228       1 update.go:601] Writing file "/etc/kubernetes/kubeconfig"
    I0415 14:19:16.420967       1 update.go:538] Writing systemd unit "kubelet.service"
    I0415 14:19:16.422581       1 update.go:573] Enabling systemd unit "kubelet.service"
    I0415 14:19:16.422697       1 update.go:500] Enabled kubelet.service
    I0415 14:19:16.422707       1 update.go:538] Writing systemd unit "mcd-write-pivot-reboot.service"
    I0415 14:19:16.424116       1 update.go:573] Enabling systemd unit "mcd-write-pivot-reboot.service"
    I0415 14:19:16.424168       1 update.go:500] Enabled mcd-write-pivot-reboot.service
    I0415 14:19:16.424450       1 update.go:720] machine-config-daemon initiating reboot: runOnceFromIgnition complete
    I0415 14:19:16.427705       1 update.go:766] MCD is not rebooting in onceFrom with --skip-reboot
    I0415 14:19:16.427724       1 start.go:194] Shutting down MachineConfigDaemon
@runcom

This comment has been minimized.

Copy link
Member Author

runcom commented Apr 15, 2019

/hold cancel

@cgwalters

This comment has been minimized.

Copy link
Contributor

cgwalters commented Apr 15, 2019

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Apr 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ashcrow,cgwalters,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runcom

This comment has been minimized.

Copy link
Member Author

runcom commented Apr 15, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2698447 into openshift:master Apr 15, 2019

6 checks passed

ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-op Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
ci/prow/verify Job succeeded.
Details
tide In merge pool.
Details

@runcom runcom deleted the runcom:skip-reboot-mcd branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.