Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-go.sh: use SOURCE_GIT_COMMIT if available #743

Merged
merged 1 commit into from May 14, 2019

Conversation

sosiouxme
Copy link
Member

This will be supplied in downstream builds to relay the commit from the source git repo.

Fixes: bz 1709365

- How to verify it
Check that the resulting OCP image built binary reports a commit from this github repo.

- Description for the changelog
build-go.sh: use SOURCE_GIT_COMMIT if available

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2019
@sosiouxme
Copy link
Member Author

@runcom @smarterclayton OS_GIT_COMMIT was breaking origin builds so I went ahead and changed it to SOURCE_GIT_COMMIT at least to get us unblocked. It's not that hard to change later.

@cgwalters
Copy link
Member

Oh whee I should have read later GH notifications...

@cgwalters
Copy link
Member

Why does #744 exist too?

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2019
@cgwalters
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2019
@sosiouxme
Copy link
Member Author

master vs release-4.1
4.1 is now building from release-4.1 so this one is more urgent

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2019
@sosiouxme
Copy link
Member Author

/retest

The other name caused problems with origin images.
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 14, 2019
@cgwalters
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sosiouxme
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@runcom
Copy link
Member

runcom commented May 14, 2019

wait, has the scaleup job been enabled by default? @vrutkovs

@vrutkovs
Copy link
Member

@runcom not sure why this happened, openshift/release#3781 would fix that

@runcom
Copy link
Member

runcom commented May 14, 2019

@runcom not sure why this happened, openshift/release#3781 would fix that

maybe because of the branching - that's the direction we're heading towards anyway though, but not there yet so yeah, let's lift that for now

@vrutkovs
Copy link
Member

Feel free to override if it fails

@openshift-ci-robot
Copy link
Contributor

@sosiouxme: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-rhel-scaleup 4bae977 link /test e2e-rhel-scaleup

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
Copy link
Member

/override e2e-rhel-scaleup

@openshift-ci-robot
Copy link
Contributor

@cgwalters: cgwalters unauthorized: /override is restricted to repo administrators

In response to this:

/override e2e-rhel-scaleup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imcleod
Copy link
Contributor

imcleod commented May 14, 2019

/override e2e-rhel-scaleup

@openshift-ci-robot
Copy link
Contributor

@imcleod: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-rhel-scaleup

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-op
  • ci/prow/e2e-aws-upgrade
  • ci/prow/e2e-rhel-scaleup
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

/override e2e-rhel-scaleup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imcleod
Copy link
Contributor

imcleod commented May 14, 2019

/override ci/prow/e2e-rhel-scaleup

@openshift-ci-robot
Copy link
Contributor

@imcleod: Overrode contexts on behalf of imcleod: ci/prow/e2e-rhel-scaleup

In response to this:

/override ci/prow/e2e-rhel-scaleup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 15b60a6 into openshift:release-4.1 May 14, 2019
@sosiouxme sosiouxme deleted the patch-2 branch May 14, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants