Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-go.sh: OS_GIT_COMMIT => SOURCE_GIT_COMMIT #744

Merged
merged 1 commit into from May 14, 2019

Conversation

sosiouxme
Copy link
Member

This will be supplied in downstream builds to relay the commit from the source git repo.

Fixes: bz 1709365

- How to verify it
Check that the resulting OCP image built binary reports a commit from this github repo.

- Description for the changelog
build-go.sh: use SOURCE_GIT_COMMIT if available

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2019
@cgwalters
Copy link
Member

I liked the commit message on the other one better, and we should have been using cherrypick right?

Also while we'e reworking this I probably would have preferred adding SOURCE_DATE_EPOCH handling in addition. But eh.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sosiouxme
Copy link
Member Author

I can probably add the EPOCH envvar in doozer pretty easily and you can use it at will.

@sosiouxme sosiouxme changed the title OS_GIT_COMMIT => SOURCE_GIT_COMMIT build-go.sh: OS_GIT_COMMIT => SOURCE_GIT_COMMIT May 14, 2019
@openshift-merge-robot openshift-merge-robot merged commit cc089a4 into openshift:master May 14, 2019
@wking
Copy link
Member

wking commented May 14, 2019

What happened to OS_GIT_COMMIT, after #738 explicitly pivoted to it?

@sosiouxme sosiouxme deleted the patch-3 branch May 14, 2019 04:10
@sosiouxme
Copy link
Member Author

@wking builds from origin didn't like it, see #aos-art

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants