Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cloud platform labelling #136

Merged

Conversation

@cblecker
Copy link
Member

cblecker commented Nov 11, 2019

No description provided.

cblecker added 4 commits Nov 11, 2019
@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Nov 11, 2019

/cc @mjudeikis @rogbas @jewzaam

This might be a simpler solution for cloud platform labelling than #123, and consistent with @rogbas' use of the upsert directory. Let me know what you think.

@openshift-ci-robot openshift-ci-robot requested review from mjudeikis and rogbas Nov 11, 2019
@mjudeikis

This comment has been minimized.

Copy link

mjudeikis commented Nov 11, 2019

Im ok any way as long as it delivers the same result.

@mjudeikis

This comment has been minimized.

Copy link

mjudeikis commented Nov 12, 2019

/lgtm

@jewzaam

This comment has been minimized.

Copy link
Member

jewzaam commented Nov 12, 2019

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jewzaam, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker cblecker changed the title [WIP] add cloud platform labelling add cloud platform labelling Nov 12, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1260b94 into openshift:master Nov 12, 2019
3 checks passed
3 checks passed
ci.ext.devshift.net PR build
Details
ci/prow/images Job succeeded.
Details
tide In merge pool.
Details
@cblecker cblecker deleted the cblecker:cloud-platform-labelling branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.