Remove managed-velero-operator #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 13, 2019 18:44
Managed-velero-operator is now deployed using the app-sre pipeline. openshift/managed-velero-operator#20
openshift-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dak1n1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dak1n1
requested review from
jharrington22
and removed request for
mwoodson and
aweiteka
cblecker
requested changes
Dec 14, 2019
| @@ -1,6 +0,0 @@ | |||
| apiVersion: v1 | |||
| kind: Namespace | |||
There was a problem hiding this comment.
I think deleting this will delete the NS and the Velero CRs
There was a problem hiding this comment.
I tested in hive-stage, and it appears to keep the namespace and CR around when the SelectorSyncSet is deleted.
openshift-ci-robot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managed-velero-operator is now deployed using the app-sre pipeline.
openshift/managed-velero-operator#20