Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scoped labels for resource quota exemption #29

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@cblecker
Copy link
Member

commented Jun 6, 2019

This changes the labels used for resource quota exemption to use the scoped "managed.openshift.io" namespace. This way, it's easy to tell that these settings are specific to the OSD offering.

I've also swapped the negative label value for a positive one. As we're using DoesNotExist as the match operator, this makes the two possible states 'true' if the namespace is exempt, and the label should be omitted completely for normal namespaces.

Use scoped labels for resource quota exemption
This changes the labels used for resource quota exemption to use
the scoped "managed.openshift.io" namespace. This way, it's easy to tell
that these settings are specific to the OSD offering.

I've also swapped the negative label value for a positive one. As we're
using `DoesNotExist` as the match operator, this makes the two possible
states 'true' if the namespace is exempt, and the label should be
omitted completely for normal namespaces.
@cblecker

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

/assign @lisa

This is a totally optional improvement on this operator, @lisa. I'm not sure if there are specific reasons for the way it was, but I was digging through this code when I ran into an issue on my own cluster and these improvements made sense to me.

@lisa

lisa approved these changes Jun 6, 2019

Copy link
Contributor

left a comment

Good readability changes! :shipit:

/lgtm

@cblecker cblecker merged commit 67fbb8c into openshift:master Jun 6, 2019

1 check passed

ci.ext.devshift.net PR build
Details

@cblecker cblecker deleted the cblecker:scoped-label-quota branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.