Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getopts and usage #73

Open
wants to merge 1 commit into
base: master
from

Conversation

@jharrington22
Copy link
Collaborator

commented Aug 8, 2019

@jewzaam @mwoodson my attempt to make script a little safer. With these changes you can run the script without arguments and it will print the usage (still) but adding a specific option for status and upgrade versions. Thoughts?

@jharrington22

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

I've tested the status option but not the upgrade.

Show resolved Hide resolved scripts/cluster-upgrade.sh Outdated
Show resolved Hide resolved scripts/cluster-upgrade.sh
@jharrington22

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

I'll squash before merge, so please don't lgtm @lisa @cblecker

@jharrington22 jharrington22 force-pushed the jharrington22:add-getopts-and-usage branch from cd3a623 to cc977d8 Aug 9, 2019

@jharrington22 jharrington22 force-pushed the jharrington22:add-getopts-and-usage branch from cc977d8 to e745b4c Aug 9, 2019

Show resolved Hide resolved scripts/cluster-upgrade.sh

@jharrington22 jharrington22 force-pushed the jharrington22:add-getopts-and-usage branch from e745b4c to 2eea25a Aug 9, 2019

@lisa

lisa approved these changes Aug 9, 2019

Copy link
Contributor

left a comment

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Aug 9, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jharrington22, lisa
To complete the pull request process, please assign mwoodson
You can assign the PR to them by writing /assign @mwoodson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Member

left a comment

one question, otherwise lgtm

done


OCP_VERSION_FROM=OSD_UPGRADE_FROM

This comment has been minimized.

Copy link
@cblecker

cblecker Aug 9, 2019

Member

Why do we set this as one name from getops, and then set it to the exact same thing down here? Seems redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.