Skip to content

Conversation

@machadovilaca
Copy link
Member

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: machadovilaca
Once this PR has been reviewed and has the lgtm label, please assign peteryurkovich for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@machadovilaca
Copy link
Member Author

/cc @avlitman @sradco

@openshift-ci openshift-ci bot requested review from avlitman and sradco November 25, 2025 16:51
@simonpasquier
Copy link
Contributor

/cc @simonpasquier

@openshift-ci openshift-ci bot requested a review from simonpasquier November 25, 2025 17:18
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a separate PR on main for the golangci-lint addition? It's very much appreciated but it'd be easier to review separately. Can we also have a minimal golangci-lint configuration? Once this is done we should also consider adding a job to openshift/release to enforce the verification.
Regarding goimports, I'd recommend using the gci linter which does the same IIUC.

@machadovilaca machadovilaca force-pushed the add-alert-management-api-base branch from cfc4748 to dc61cb7 Compare November 26, 2025 13:16
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
@machadovilaca machadovilaca force-pushed the add-alert-management-api-base branch from dc61cb7 to 5aad6ea Compare November 26, 2025 13:17
@machadovilaca
Copy link
Member Author

Can we have a separate PR on main for the golangci-lint addition? It's very much appreciated but it'd be easier to review separately. Can we also have a minimal golangci-lint configuration? Once this is done we should also consider adding a job to openshift/release to enforce the verification. Regarding goimports, I'd recommend using the gci linter which does the same IIUC.

removed for now, will create a PR to add it separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants