Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CGO_ENABLED=0 to build #12

Merged
merged 2 commits into from Apr 17, 2019
Merged

add CGO_ENABLED=0 to build #12

merged 2 commits into from Apr 17, 2019

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Apr 17, 2019 •
edited by smarterclayton

Fixes break where libcrypto is being referenced:

erroring out with: /var/lib/cni/bin/multus: error while loading shared libraries: libcrypto.so.10: cannot open shared object file: No such file or directory apparently the last working build was 4.0.0-0.nightly-2019-04-10-182914

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2019
@dougbtv
Copy link
Member Author

dougbtv commented Apr 17, 2019

/retest

@squeed
Copy link

squeed commented Apr 17, 2019

Checked that the resulting binary is static:

[root@d6f60130d8a0 /]# ldd ./usr/src/multus-cni/bin/multus
        not a dynamic executable

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@wking
Copy link
Member

wking commented Apr 17, 2019

Cross-ref https://bugzilla.redhat.com/show_bug.cgi?id=1700504

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@smarterclayton
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, smarterclayton, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dougbtv
Copy link
Member Author

dougbtv commented Apr 17, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit dd8e7c3 into master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@jeremyeder jeremyeder Awaiting requested review from jeremyeder

Assignees

@squeed squeed

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dougbtv @squeed @wking @smarterclayton @openshift-ci-robot @openshift-merge-robot