Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1735363: must-gather should redact kubectl.kubernetes.io/last-applied-configuration in secrets #116

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #115

/assign deads2k

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.1] Bug 1723472: must-gather should redact kubectl.kubernetes.io/last-applied-configuration in secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2019
@sanchezl
Copy link
Contributor

/retitle Bug 1735363: must-gather should redact kubectl.kubernetes.io/last-applied-configuration in secrets

@openshift-ci-robot openshift-ci-robot changed the title [release-4.1] Bug 1723472: must-gather should redact kubectl.kubernetes.io/last-applied-configuration in secrets Bug 1735363: must-gather should redact kubectl.kubernetes.io/last-applied-configuration in secrets Jul 31, 2019
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 31, 2019
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1735363: must-gather should redact kubectl.kubernetes.io/last-applied-configuration in secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis
Copy link
Member

eparis commented Aug 20, 2019

/bugzilla refresh
looks like this need lgtm/approval from the team

@openshift-ci-robot
Copy link

@eparis: This pull request references Bugzilla bug 1735363, which is valid.

In response to this:

/bugzilla refresh
looks like this need lgtm/approval from the team

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2019
@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit 5f97b2a into openshift:release-4.1 Aug 24, 2019
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1735363 has been moved to the MODIFIED state.

In response to this:

Bug 1735363: must-gather should redact kubectl.kubernetes.io/last-applied-configuration in secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants